Skip to content

Alex/update test runner#95

Draft
AlexBrandes wants to merge 1 commit intorelease/mainnetfrom
alex/update-test-runner
Draft

Alex/update test runner#95
AlexBrandes wants to merge 1 commit intorelease/mainnetfrom
alex/update-test-runner

Conversation

@AlexBrandes
Copy link
Member

Fixes broken test runner on obsolete Ubuntu image

@AlexBrandes AlexBrandes changed the base branch from develop to release/mainnet May 23, 2025 15:55
@AlexBrandes AlexBrandes marked this pull request as draft May 23, 2025 15:56
Copy link

@ryle-ai ryle-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI Runner Update Review

Small change, verified the scope: updates runs-on from ubuntu-20.04 to ubuntu-latest in both pull_request.yml and release.yml. This is reasonable — Ubuntu 20.04 reached EOL in April 2025 and GitHub has deprecated it as a runner image.

What I checked

  • Both workflow files on the PR branch — confirmed both now use ubuntu-latest, change is consistent across the two files.
  • deploy.yml — the newer deploy workflow (added in #116) uses ubuntu-22.04 for the build job and ubuntu-latest for deploy jobs. Not touched by this PR, which is fine since it's already on a supported image.
  • Action versions — both pull_request.yml and release.yml still use actions/checkout@v3 and actions/setup-java@v3, while deploy.yml uses @v4 for both. Not a blocker for this PR, but worth updating in a follow-up to stay consistent.
  • Java version — both workflows pin Java 11 and reference tessellation v2.12.0. The deploy.yml has a separate path for testnet that uses Java 21. No conflict introduced here.
  • Cross-repo patterns — tessellation and ded repos have largely standardized on ubuntu-22.04 for Scala build jobs. Using ubuntu-latest is fine and will float forward, but just noting the difference in convention.

Minor observations (non-blocking)

  1. These two workflow files (pull_request.yml and release.yml) appear to be legacy — the newer deploy.yml handles the release/deploy pipeline with a more modern setup (v4 actions, permissions block, artifact-based flow). If release.yml is still actively used for tag-based releases, it might be worth modernizing it to match deploy.yml's patterns at some point.
  2. The release.yml uses the deprecated ::set-output syntax (echo "::set-output name=version::...") which GitHub has been warning about. Not introduced by this PR, just noting it's there.

Looks good overall. The change is correct and addresses the runner deprecation.

runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- name: Checkout code
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: while you're here, actions/checkout@v3 and actions/setup-java@v3 are both one major version behind (deploy.yml already uses @v4). Might be worth bumping these in a follow-up to stay consistent across the repo's workflows.

Copy link

@ryle-ai ryle-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward and correct fix. Ubuntu 20.04 reached EOL in April 2025 and GitHub has deprecated it as a runner image, so this is necessary maintenance.

What I verified

  • Both pull_request.yml and release.yml are updated consistently to ubuntu-latest.
  • deploy.yml (the newer workflow from #116) already uses ubuntu-latest for its deploy jobs and ubuntu-22.04 for the build job — no conflicts introduced.
  • The change is scoped to just the runner image; no other workflow behavior is affected.

Pre-existing observations (non-blocking, not introduced by this PR)

  • Both pull_request.yml and release.yml still use actions/checkout@v3 and actions/setup-java@v3, while deploy.yml uses @v4. Worth bumping in a follow-up for consistency.
  • release.yml uses the deprecated ::set-output syntax — GitHub has been warning about this for a while. Not urgent but should be addressed eventually.
  • These two legacy workflows pin tessellation to v2.12.0 and Java 11, while deploy.yml's testnet path uses Java 21 and builds tessellation from the release branch. If these legacy workflows are still actively used, they may need modernization at some point.

Looks good.

Copy link

@ryle-ai ryle-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward and correct fix. Ubuntu 20.04 reached EOL in April 2025 and GitHub has deprecated it as a runner image, so this update is necessary.

What I verified

  • Both pull_request.yml and release.yml are updated consistently from ubuntu-20.04 to ubuntu-latest.
  • The base branch (release/mainnet) still has ubuntu-20.04 in both files — confirmed this PR is the correct fix.
  • deploy.yml (added in #116, present on develop) already uses ubuntu-22.04 for the build job and ubuntu-latest for deploy jobs — no conflicts introduced by this change.
  • The PR is a single commit (1ab5d17) scoped entirely to the runner image; no other workflow behavior is affected.

Pre-existing observations (non-blocking, not introduced by this PR)

  • Both pull_request.yml and release.yml still use actions/checkout@v3 and actions/setup-java@v3, while deploy.yml uses @v4. Worth bumping in a follow-up for consistency.
  • release.yml uses the deprecated ::set-output syntax — should be migrated to $GITHUB_OUTPUT eventually.
  • release.yml references ${{ steps.build_changelog.outputs.changelog }} in the release body, but the changelog step is commented out, so the release body would always be empty. Not introduced by this PR, but worth noting.
  • Both legacy workflows pin tessellation to v2.12.0 and Java 11. If these workflows are still actively used alongside deploy.yml, they may need modernization at some point.

Looks good.

Copy link

@ryle-ai ryle-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward and correct. Ubuntu 20.04 reached EOL in April 2025 and GitHub has deprecated it as a runner image, so this update is necessary.

What I verified

  • Both pull_request.yml and release.yml are updated consistently from ubuntu-20.04 to ubuntu-latest.
  • Confirmed the base branch (release/mainnet) still has ubuntu-20.04 in both files — this PR is the correct fix.
  • deploy.yml (on develop, added in #116) already uses ubuntu-22.04 for the build job and ubuntu-latest for deploy jobs — no conflicts introduced.
  • Single commit (1ab5d17) scoped entirely to the runner image; no other workflow behavior is affected.

Pre-existing observations (non-blocking, not introduced by this PR)

  1. Both pull_request.yml and release.yml still use actions/checkout@v3 and actions/setup-java@v3, while deploy.yml uses @v4. Worth bumping in a follow-up for consistency.
  2. release.yml uses the deprecated ::set-output syntax — should be migrated to $GITHUB_OUTPUT.
  3. release.yml references ${{ steps.build_changelog.outputs.changelog }} in the release body, but the changelog step is commented out, so the release body will always be empty.
  4. Both legacy workflows pin tessellation to v2.12.0 and Java 11. If these workflows are still actively used alongside deploy.yml, they may need modernization.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants