Conversation
ryle-ai
left a comment
There was a problem hiding this comment.
CI Runner Update Review
Small change, verified the scope: updates runs-on from ubuntu-20.04 to ubuntu-latest in both pull_request.yml and release.yml. This is reasonable — Ubuntu 20.04 reached EOL in April 2025 and GitHub has deprecated it as a runner image.
What I checked
- Both workflow files on the PR branch — confirmed both now use
ubuntu-latest, change is consistent across the two files. deploy.yml— the newer deploy workflow (added in #116) usesubuntu-22.04for the build job andubuntu-latestfor deploy jobs. Not touched by this PR, which is fine since it's already on a supported image.- Action versions — both
pull_request.ymlandrelease.ymlstill useactions/checkout@v3andactions/setup-java@v3, whiledeploy.ymluses@v4for both. Not a blocker for this PR, but worth updating in a follow-up to stay consistent. - Java version — both workflows pin Java 11 and reference tessellation
v2.12.0. Thedeploy.ymlhas a separate path for testnet that uses Java 21. No conflict introduced here. - Cross-repo patterns — tessellation and ded repos have largely standardized on
ubuntu-22.04for Scala build jobs. Usingubuntu-latestis fine and will float forward, but just noting the difference in convention.
Minor observations (non-blocking)
- These two workflow files (
pull_request.ymlandrelease.yml) appear to be legacy — the newerdeploy.ymlhandles the release/deploy pipeline with a more modern setup (v4 actions, permissions block, artifact-based flow). Ifrelease.ymlis still actively used for tag-based releases, it might be worth modernizing it to matchdeploy.yml's patterns at some point. - The
release.ymluses the deprecated::set-outputsyntax (echo "::set-output name=version::...") which GitHub has been warning about. Not introduced by this PR, just noting it's there.
Looks good overall. The change is correct and addresses the runner deprecation.
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code |
There was a problem hiding this comment.
Nit: while you're here, actions/checkout@v3 and actions/setup-java@v3 are both one major version behind (deploy.yml already uses @v4). Might be worth bumping these in a follow-up to stay consistent across the repo's workflows.
ryle-ai
left a comment
There was a problem hiding this comment.
Straightforward and correct fix. Ubuntu 20.04 reached EOL in April 2025 and GitHub has deprecated it as a runner image, so this is necessary maintenance.
What I verified
- Both
pull_request.ymlandrelease.ymlare updated consistently toubuntu-latest. deploy.yml(the newer workflow from #116) already usesubuntu-latestfor its deploy jobs andubuntu-22.04for the build job — no conflicts introduced.- The change is scoped to just the runner image; no other workflow behavior is affected.
Pre-existing observations (non-blocking, not introduced by this PR)
- Both
pull_request.ymlandrelease.ymlstill useactions/checkout@v3andactions/setup-java@v3, whiledeploy.ymluses@v4. Worth bumping in a follow-up for consistency. release.ymluses the deprecated::set-outputsyntax — GitHub has been warning about this for a while. Not urgent but should be addressed eventually.- These two legacy workflows pin tessellation to
v2.12.0and Java 11, whiledeploy.yml's testnet path uses Java 21 and builds tessellation from the release branch. If these legacy workflows are still actively used, they may need modernization at some point.
Looks good.
ryle-ai
left a comment
There was a problem hiding this comment.
Straightforward and correct fix. Ubuntu 20.04 reached EOL in April 2025 and GitHub has deprecated it as a runner image, so this update is necessary.
What I verified
- Both
pull_request.ymlandrelease.ymlare updated consistently fromubuntu-20.04toubuntu-latest. - The base branch (
release/mainnet) still hasubuntu-20.04in both files — confirmed this PR is the correct fix. deploy.yml(added in #116, present ondevelop) already usesubuntu-22.04for the build job andubuntu-latestfor deploy jobs — no conflicts introduced by this change.- The PR is a single commit (
1ab5d17) scoped entirely to the runner image; no other workflow behavior is affected.
Pre-existing observations (non-blocking, not introduced by this PR)
- Both
pull_request.ymlandrelease.ymlstill useactions/checkout@v3andactions/setup-java@v3, whiledeploy.ymluses@v4. Worth bumping in a follow-up for consistency. release.ymluses the deprecated::set-outputsyntax — should be migrated to$GITHUB_OUTPUTeventually.release.ymlreferences${{ steps.build_changelog.outputs.changelog }}in the release body, but the changelog step is commented out, so the release body would always be empty. Not introduced by this PR, but worth noting.- Both legacy workflows pin tessellation to
v2.12.0and Java 11. If these workflows are still actively used alongsidedeploy.yml, they may need modernization at some point.
Looks good.
ryle-ai
left a comment
There was a problem hiding this comment.
Straightforward and correct. Ubuntu 20.04 reached EOL in April 2025 and GitHub has deprecated it as a runner image, so this update is necessary.
What I verified
- Both
pull_request.ymlandrelease.ymlare updated consistently fromubuntu-20.04toubuntu-latest. - Confirmed the base branch (
release/mainnet) still hasubuntu-20.04in both files — this PR is the correct fix. deploy.yml(ondevelop, added in #116) already usesubuntu-22.04for the build job andubuntu-latestfor deploy jobs — no conflicts introduced.- Single commit (
1ab5d17) scoped entirely to the runner image; no other workflow behavior is affected.
Pre-existing observations (non-blocking, not introduced by this PR)
- Both
pull_request.ymlandrelease.ymlstill useactions/checkout@v3andactions/setup-java@v3, whiledeploy.ymluses@v4. Worth bumping in a follow-up for consistency. release.ymluses the deprecated::set-outputsyntax — should be migrated to$GITHUB_OUTPUT.release.ymlreferences${{ steps.build_changelog.outputs.changelog }}in the release body, but the changelog step is commented out, so the release body will always be empty.- Both legacy workflows pin tessellation to
v2.12.0and Java 11. If these workflows are still actively used alongsidedeploy.yml, they may need modernization.
Looks good.
Fixes broken test runner on obsolete Ubuntu image