Conversation
ryle-ai
left a comment
ryle-ai
left a comment
There was a problem hiding this comment.
Small and focused fix -- the current develop branch is missing the incrementalDelegatedStakingStartingOrdinal parameter in GlobalSnapshotContextFunctions.make() call (in TessellationServices.scala) and in the SharedConfig constructor (in Configuration.scala). This PR threads it through from the tessellation SharedConfigReader, which aligns with how SharedServices does it in tessellation proper (modules/node-shared/.../SharedServices.scala:182).
One note -- this has merge conflicts currently (status: CONFLICTING). The develop branch has moved forward with things like the clickHouseConfig and mptSnapshotInfoPath fields in SharedConfig, and the PR's Configuration.scala is based on an older shape. Should be a straightforward rebase but needs to happen before merge.
Also bumps the tessellation SNAPSHOT dep from d69174b96 to 5a4c2be69 -- I'm guessing this is the build that includes the incrementalDelegatedStakingStartingOrdinal parameter in GlobalSnapshotContextFunctions.make. Makes sense.
🤖 ryle-ai automated review
3 participants
No description provided.