Skip to content

Checkpoint block validation docs#1319

Open
kpudlik wants to merge 1 commit intodevfrom
cb-validation-docs
Open

Checkpoint block validation docs#1319
kpudlik wants to merge 1 commit intodevfrom
cb-validation-docs

Conversation

@kpudlik
Copy link
Contributor

@kpudlik kpudlik commented Jul 29, 2020

No description provided.

@kpudlik kpudlik force-pushed the cb-validation-docs branch from 0fa67d0 to 1c0d5df Compare July 29, 2020 09:07
@kpudlik kpudlik force-pushed the cb-validation-docs branch from 1c0d5df to 77a5288 Compare July 29, 2020 09:08
of block - the hash should be different. If hash is different or does not match the content of block then such block
is rejected because is malformed.

## Balance validation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add info about double spend validation somewhere and a hint about blacklisting. If address performed a double spend it's actually being blacklisted forever (I think until rollback actually but Wyatt mentioned it was intended to be forever).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I'm not sure if double spend can be even performed at this point with checks we introduced in POST /transaction endpoint and pull for consensus logic. Still the check is there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But maybe that's not a part of checkpoint block validation, but rather docs for checkpointAcceptanceService

If sum is bigger than current balance then address has `InsufficientBalance` and block is incorrect because
wallet has not enough tokens to send all the transactions from block.

### Staking amount validation (for node wallets)
Copy link
Contributor

@TheMMaciek TheMMaciek Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this check is not really working. I remember that it will only work if a node processes it's own transaction, so in most cases it will not get triggered. So i'm not sure we should put it in docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants