Open
Conversation
Contributor
|
That change is valid only if there is no semantic difference between list that doesn't exist and list that exists but is empty. Have you confirmed that there is no difference for that particular case? We also often use |
Contributor
Author
|
well... this is actually closer to the |
fefa630 to
1b9c7ed
Compare
1b9c7ed to
9ce83bb
Compare
9ce83bb to
97903f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace
NonEmptyMap[Addr, Option[List[Info]]]withNonEmptyMap[Addr, List[Info]]]