Denylist reload #101
Denylist reload #101
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
| log.info( | ||
| "Registering Linea plugin of type {} with name {}", | ||
| this.getClass().getName(), | ||
| this.getName()); |
There was a problem hiding this comment.
if plugin name == class name this extra logging may not be useful
|
|
||
| @Override | ||
| public CompletableFuture<Void> reloadConfiguration() { | ||
| loadDenyListAndRegisterPluginTxValidatorFactory(); |
There was a problem hiding this comment.
need to look at rejectedTxJsonRpcManager - may need to do something different with that re start/stop lifecycle
There was a problem hiding this comment.
factory field in TransactionPoolValidatorServiceImpl is not volatile so the change could not be seen immediately by all thread, said that I prefer that the registration is done one, and the reload only updates the deny list, so for example restricting the moving pieces to a wrap of the deny list in a mutable container that is set at startup and updated on every reload, without having to redo all the initialization of the plugin
fab-10
left a comment
fab-10
left a comment
There was a problem hiding this comment.
Nice to learn that we already have a way to trigger a reload of the plugin conf.
Shared a comment with my view on how the conf reload should only touch the deny list
|
|
||
| @Override | ||
| public CompletableFuture<Void> reloadConfiguration() { | ||
| loadDenyListAndRegisterPluginTxValidatorFactory(); |
There was a problem hiding this comment.
factory field in TransactionPoolValidatorServiceImpl is not volatile so the change could not be seen immediately by all thread, said that I prefer that the registration is done one, and the reload only updates the deny list, so for example restricting the moving pieces to a wrap of the deny list in a mutable container that is set at startup and updated on every reload, without having to redo all the initialization of the plugin
2 participants
allow config reload for LineaTransactionPoolValidatorPlugin.
Simplest possible implementation with no optimization.
Built on top of #99