Skip to content

Improve SCSS cache directory creation and error handling #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shadoath wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Improve SCSS cache directory creation and error handling #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions class/class-wp-scss.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public function compile() {
private function compiler($in, $out) {

if (!file_exists($this->cache)) {
mkdir($this->cache, 0644);
wp_mkdir_p($this->cache);
}
if (is_writable($this->cache)) {
try {
Expand All @@ -176,9 +176,12 @@ private function compiler($in, $out) {
array_push($this->compile_errors, $errors);
}
} else {
$message = !file_exists($this->cache)
? "File Permission Error, unable to create the cache directory. Please manually create: " . $this->cache
: "File Permission Error, permission denied. Please make the cache directory writable.";
$errors = array (
'file' => $this->cache,
'message' => "File Permission Error, permission denied. Please make the cache directory writable."
'message' => $message
);
array_push($this->compile_errors, $errors);
}
Expand Down