Skip to content
This repository was archived by the owner on Oct 13, 2025. It is now read-only.

Conversation

@EricKarschner37
Copy link
Contributor

@EricKarschner37 EricKarschner37 commented Oct 16, 2019

Two main overhauls made:
-MainActivity now handles sign in for google account, EventActivity holds the Fragments which are responsible for the status, schedule, and quickmode views.
-EventActivityViewModel is now used to access and hold Calendar Event data. Each fragment can access the viewmodel and use it to view the events.

@WillNilges
Copy link
Member

Summarize your commits, headass.

@WillNilges
Copy link
Member

I'll look it over later tonight.

@WillNilges
Copy link
Member

WillNilges commented Oct 22, 2019

Fugma give me a second to stop drowning I have so many exams I promise I'll review your PR <3 <3

@WillNilges
Copy link
Member

Looks good so far, but I'd like to see some more polish on it. Please continue to work on it and write up a readme on new features.

@WillNilges
Copy link
Member

So I'm getting an issue on the new build where if I try to enter Kiosk mode, I get an error saying "Not Owner." Know anything about that?

@WillNilges
Copy link
Member

HAHAHA THIS IS STILL PENDING

@WillNilges
Copy link
Member

My deepest apologies, but I can no longer get this to run. Uhhhh, can you see if you can?

@WillNilges
Copy link
Member

Do you think you could break this up into a few different little PR's? Now that I'm sitting down and picking through it (2 years later) there's a few different features rolled into one. The thing that I'm most interested in, for sure, is the way you're handling sign in and retrieval of calendar data. We can talk about the rest separately.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants