-
Notifications
You must be signed in to change notification settings - Fork 4
Develop #22
base: master
Are you sure you want to change the base?
Develop #22
Conversation
|
Summarize your commits, headass. |
|
I'll look it over later tonight. |
…from their phones
|
Fugma give me a second to stop drowning I have so many exams I promise I'll review your PR <3 <3 |
|
Looks good so far, but I'd like to see some more polish on it. Please continue to work on it and write up a readme on new features. |
|
So I'm getting an issue on the new build where if I try to enter Kiosk mode, I get an error saying "Not Owner." Know anything about that? |
|
HAHAHA THIS IS STILL PENDING |
|
My deepest apologies, but I can no longer get this to run. Uhhhh, can you see if you can? |
|
Do you think you could break this up into a few different little PR's? Now that I'm sitting down and picking through it (2 years later) there's a few different features rolled into one. The thing that I'm most interested in, for sure, is the way you're handling sign in and retrieval of calendar data. We can talk about the rest separately. |
Two main overhauls made:
-MainActivity now handles sign in for google account, EventActivity holds the Fragments which are responsible for the status, schedule, and quickmode views.
-EventActivityViewModel is now used to access and hold Calendar Event data. Each fragment can access the viewmodel and use it to view the events.