Draft
Conversation
…ries and packages
convert to new Scala 3 syntax
SpirvTools are now integrated into the flow.
szymon-rd
reviewed
Jun 19, 2025
cyfra-rtrp/src/main/scala/io/computenode/cyfra/rtrp/window/WindowManager.scala
Outdated
Show resolved
Hide resolved
cyfra-rtrp/src/main/scala/io/computenode/cyfra/rtrp/window/platform/GLFWWindowSystem.scala
Outdated
Show resolved
Hide resolved
| var running = true | ||
| var frameCount = 0 | ||
|
|
||
| while (running && !window.shouldClose) { |
Member
There was a problem hiding this comment.
I think we should have an abstraction over the "game loop", but probably not at this stage. In what part could we put it later on?
Collaborator
Author
There was a problem hiding this comment.
maybe new gameloop or engine-like module
* Added "-feature", "-deprecation", "-unchecked", "-language:implicitConversions" to scalacOptions
Whole code base should now use Scala3 new syntax and significant indents. If anyone sees unnecessary {} that I missed, please get rid of them.
2d374c6 to
47ed129
Compare
rtrp-surface
753c207 to
0c06865
Compare
ef11eaa to
b605d8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Window Management Details
Core Components
Window Interface:
WindowConfig:
WindowSystem Interface:
WindowEvents:
GLFW-Specific Components
GLFWWindow:
Windowinterface using GLFW. Handles window-specific operations like resizing and input events.GLFWWindowSystem:
WindowSysteminterface using GLFW. Manages the lifecycle of windows and integrates Vulkan support.WindowManager
The
WindowManageris a higher-level class that simplifies working with windows. It acts as a wrapper around theWindowSystemand provides methods to:Example
The
WindowSystemExamplefile shows how to use theWindowManagerto create windows and respond to events like resizing or key presses.