Skip to content

Optional no shadow root. Fix attribute marshalling on pages with full Polymer. Add querySelector shortcut. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patternseek wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Optional no shadow root. Fix attribute marshalling on pages with full Polymer. Add querySelector shortcut. #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbf0668
Allow creation of components with no shadow dom by setting 'noshadowr…
patternseek Jan 27, 2016
8175c42
Use _takeAttributesToModel() instead of _marshalAttributes() as the l…
patternseek Jan 27, 2016
cd5fe0d
Add a small helper shortcut to this.root.querySelector, mainly for us…
patternseek Jan 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions minimalComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,11 @@ window.MinimalComponent = {
}

// Instantiate template.
this.root = this.createShadowRoot();
if (this.template.getAttribute("noshadowroot") !== null) {
this.root = this;
} else {
this.root = this.createShadowRoot();
}
var clone = document.importNode(this.template.content, true);
this.root.appendChild(clone);

Expand All @@ -61,7 +65,12 @@ window.MinimalComponent = {

// Initialize property values from attributes.
// This invokes an undocumented method internal to Polymer.
this._marshalAttributes();
this._takeAttributesToModel(this);

// Shortcut for this.root.querySelector().
// Mainly useful when not using a shadow root,
// where the this.$ syntax shouldn't really be used
this.qs = this.root.querySelector.bind(this.root);
}

};
Expand Down