-
Notifications
You must be signed in to change notification settings - Fork 765
Update ansible galaxy roles upload script #14281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ggbecker
wants to merge
7
commits into
ComplianceAsCode:master
Choose a base branch
from
ggbecker:update-ansible-roles-script
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update ansible galaxy roles upload script #14281
ggbecker
wants to merge
7
commits into
ComplianceAsCode:master
from
ggbecker:update-ansible-roles-script
+135
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
ATEX Test ResultsTest artifacts have been submitted to Testing Farm. Results: View Test Results This comment was automatically generated by the ATEX workflow. |
Previously, there was a allowlist for profiles to be uploaded, with that many new supported profiles were not being included in the ansible galaxy. Inverting the logic to a denylist will make any supported ansible role for the supported products to be uploaded automatically. At the time of this commit, profiles such as bsi ccn_advanced ccn_basic ccn_intermediate cis_server_l1 cis_workstation_l1 cis_workstation_l2 stig_gui were not being uploaded to ansible galaxy.
This makes the script future proof.
This version is required to work with the current implementation of the script. A new pygithub 2.0 version was released and broke compatibility.
The ansible galaxy init command was deleting the .git folder from a net new repository, making it unable to push the initial code to the fresh repo for a brand new ansible role. It's also fixed the missing variable for the potential collections, we now simply check if the repo name contains the prefix ansible-role-rhel.
These dependencies should be now installed by default whenever someone tries to install the CaC ansible roles. Fixes: ComplianceAsCode#9067
The script now uses pygithub to fetch the RedHatOfficial repositories to be updated and requires a github token as well to run. The release documentation has been updated to reflect this update.
930e1fc to
ce153a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
TODO List
Draft Docs: