[T2898] FIX: user menu component

[Danielgergely]

FEAT: added optional y-padding to buttons

FEAT: new 'Login' variant for buttons

FEAT: new circular option for buttons

[gemini-code-assist]

Summary of Changes

Hello @Danielgergely, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the styling capabilities of button components within the theme. It introduces greater flexibility for vertical padding through updated SCSS mixins and adds new button styles, specifically a 'login' variant and a 'circular' radius option. These new styles are then applied to the user menu component, refining its visual presentation and ensuring consistency with the new design options.

Highlights

• Button Mixin Enhancement: The button-base and compassion-button-variant SCSS mixins have been updated to include an optional padding-y parameter, allowing for more granular control over vertical padding in buttons.
• New Button Variant: A new button variant, --login-hollow, has been introduced, providing a specific style for login-related buttons.
• New Radius Modifier: A new radius modifier, --radius-circular, has been added to enable perfectly circular buttons.
• User Menu Component Update: The user menu component in template_header.xml has been updated to utilize the newly added --login button variant and --radius-circular modifier, changing its appearance.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces new button styling capabilities, specifically optional vertical padding, a new 'Login' button variant, and a 'circular' radius option. These new styles are then applied to the user menu component in the header, changing its appearance from a compact pill-shaped button to a login-specific circular button. The changes are well-implemented and consistent across the SCSS and XML files, enhancing the flexibility and visual options for buttons within the theme.

[NoeBerdoz]

Thanks for your PR!

Here is a thing to consider and a suggestion:

Did you test the behavior of the button when it has your implemented style and a label inside ?
this is how it is attended to be:

Then, i would suggest to rename &--login-hollow into something more general as it's a reusable theme attribute, for example something like &--slim-hollow

[NoeBerdoz]

Nice, thank you !