Skip to content

perf: only update groups when groups or job data is updated #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andyyy7666 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf: only update groups when groups or job data is updated #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d519e68
Enhance ND:updateCharacter event
Andyyy7666 Dec 15, 2025
c40d931
Enhance ND:updateCharacter event
Andyyy7666 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/bridge/nd/client.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ RegisterNetEvent("ND:characterLoaded", function(character)
client.setPlayerData("groups", reorderGroups(character.groups))
end)

RegisterNetEvent("ND:updateCharacter", function(character)
RegisterNetEvent("ND:updateCharacter", function(character, updatedData)
local validUpdateData = { ["job"] = true, ["groups"] = true, ["jobInfo"] = true }
if not validUpdateData[updatedData] then return end
client.setPlayerData("groups", reorderGroups(character.groups))
end)

Expand Down
5 changes: 4 additions & 1 deletion modules/bridge/nd/server.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ AddEventHandler("ND:moneyChange", function(src, account, amount, changeType, rea
Inventory.SetItem(src, "money", changeType == "set" and amount or changeType == "remove" and item - amount or changeType == "add" and item + amount)
end)

AddEventHandler("ND:updateCharacter", function(character)
AddEventHandler("ND:updateCharacter", function(character, updatedData)
local validUpdateData = { ["job"] = true, ["groups"] = true, ["jobInfo"] = true }
if not validUpdateData[updatedData] then return end

local inventory = Inventory(character.source)
if not inventory then return end
inventory.player.groups = reorderGroups(character.groups)
Expand Down