Fix syntax error in zh-cn-sync-check and redirect-check workflows #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove stray single quote from JSON example in both zh-cn-sync-check.yml and redirect-check.yml that was causing syntax errors. Fixes #118
benceruleanlu
force-pushed
the
fix-workflow-syntax-error
branch
from
4bbd725 to
8a4e5e0
Compare
The JSON example echo statements in both redirect-check.yml and zh-cn-sync-check.yml were missing their closing single quotes, causing syntax errors. This adds the missing quotes to properly close the echo commands.
Member
|
Sorry I fixed it in another way. But your solution is better |
robinjhuang
approved these changes
May 29, 2025
Member
Author
|
Actually, I didn't take a closer look until now, this shuts up the syntax complaints but I do think it does actually preserve the whitespace. We can probably just use \n. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118