Skip to content

Conversation

@fengsi
Copy link
Contributor

@fengsi fengsi commented Oct 8, 2025

No functional change here, but if we were to redefine the built-in list, we'll need to make sure that any possible references to the list type should happen before the def list() function.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Oct 8, 2025
@bigcat88
Copy link
Contributor

bigcat88 commented Oct 9, 2025

we should never name a function list.. we definitely should rename that function in a backward compatible way

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comfy_cli/command/models/models.py 50.00% 1 Missing ⚠️
@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   52.22%   52.22%           
=======================================
  Files          32       32           
  Lines        3527     3527           
=======================================
  Hits         1842     1842           
  Misses       1685     1685           
Files with missing lines Coverage Δ
comfy_cli/command/models/models.py 40.00% <50.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigcat88
Copy link
Contributor

bigcat88 commented Oct 9, 2025

thanks for this PR

@bigcat88 bigcat88 merged commit 9e169dc into Comfy-Org:main Oct 9, 2025
11 checks passed
@fengsi fengsi deleted the si/fix-list branch October 9, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants