fix: keep links hidden under bypassed nodes #7798
Conversation
dosubot
bot
added
the
size:S
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe changes refactor how bypassed nodes are visually indicated in LiteGraph. Node opacity is no longer dynamically reduced for bypassed nodes, and alpha computation no longer accounts for bypass mode. Visual distinction is now achieved solely through a color overlay, with the default bypass color updated from bright magenta to dark purple. Changes
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 12/30/2025, 03:23:24 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/30/2025, 03:14:15 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.2 MB (baseline 3.2 MB) • 🟢 -46 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 1000 kB (baseline 1000 kB) • 🟢 -87 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.63 kB (baseline 6.63 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 300 kB (baseline 300 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 199 kB (baseline 199 kB) • ⚪ 0 BReusable component library chunks
Status: 9 added / 9 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 9.1 MB (baseline 9.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.47 MB (baseline 3.47 MB) • ⚪ 0 BBundles that do not match a named category
Status: 20 added / 20 removed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vue
🧰 Additional context used
📓 Path-based instructions (13)
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vue
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
Files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vue
src/lib/litegraph/**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (src/lib/litegraph/CLAUDE.md)
src/lib/litegraph/**/*.{js,ts,jsx,tsx}: Run ESLint instead of manually figuring out whitespace fixes or other trivial style concerns using thepnpm lint:fixcommand
Take advantage ofTypedArraysubarraywhen appropriate
Thesizeandposproperties ofRectangleshare the same array buffer (subarray); they may be used to set the rectangle's size and position
Prefer single lineifsyntax over adding curly braces, when the statement has a very concise expression and concise, single line statement
Do not replace&&=or||=with=when there is no reason to do so. If you do find a reason to remove either&&=or||=, leave a comment explaining why the removal occurred
When writing methods, prefer returning idiomatic JavaScriptundefinedovernull
Files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
src/lib/litegraph/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/lib/litegraph/CLAUDE.md)
Type assertions are an absolute last resort. In almost all cases, they are a crutch that leads to brittle code
Files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,vue}: Use TypeScript exclusively; do not write new JavaScript code
Use sorted and grouped imports organized by plugin/source
Enforce ESLint rules including Vue + TypeScript rules, disallow floating promises, disallow unused imports, and restrict i18n raw text in templates
Do not useanytype oras anytype assertions; fix the underlying type issue instead
Write code that is expressive and self-documenting; avoid redundant comments and clean as you go
Keep functions short and functional; minimize nesting and follow the arrow anti-pattern
Avoid mutable state; prefer immutability and assignment at point of declaration
Use function declarations instead of function expressions when possible
Use es-toolkit for utility functions
Implement proper error handling in code
Files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vue
**/*.{ts,tsx,vue,js,jsx,json,css}
📄 CodeRabbit inference engine (AGENTS.md)
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, and 80-character line width
Files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vue
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Minimize the surface area (exported values) of each module and composable
Files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/renderer/extensions/vueNodes/components/LGraphNode.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/renderer/extensions/vueNodes/components/LGraphNode.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/renderer/extensions/vueNodes/components/LGraphNode.vue
**/*.vue
📄 CodeRabbit inference engine (AGENTS.md)
**/*.vue: Use Vue 3.5+ with TypeScript in.vuefiles, exclusively using Composition API with<script setup lang="ts">syntax
Use Tailwind 4 for styling in Vue components; avoid<style>blocks
Name Vue components using PascalCase (e.g.,MenuHamburger.vue)
Use Vue 3.5 TypeScript-style default prop declaration with reactive props destructuring; do not usewithDefaultsor runtime props declaration
Prefercomputed()overrefwithwatchwhen deriving values
PreferuseModelover separately defining prop and emit for two-way binding
Usevue-i18nin composition API for string literals; place new translation entries insrc/locales/en/main.json
Usecn()utility function from@/utils/tailwindUtilfor merging Tailwind class names; do not use:class="[]"syntax
Do not use thedark:Tailwind variant; use semantic values from thestyle.csstheme instead (e.g.,bg-node-component-surface)
Do not use!importantor the!important prefix for Tailwind classes; find and correct interfering!importantclasses instead
Avoid new usage of PrimeVue components; use VueUse, shadcn/vue, or Reka UI instead
Leverage VueUse functions for performance-enhancing styles in Vue components
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/renderer/extensions/vueNodes/components/LGraphNode.vue
🧠 Learnings (14)
📓 Common learnings
Learnt from: simula-r
Repo: Comfy-Org/ComfyUI_frontend PR: 7252
File: src/renderer/extensions/vueNodes/components/ImagePreview.vue:151-158
Timestamp: 2025-12-11T03:55:57.926Z
Learning: In src/renderer/extensions/vueNodes/components/ImagePreview.vue and LGraphNode.vue, keyboard navigation for image galleries should respond to node-level focus (via keyEvent injection from LGraphNode), not require focus within the image preview wrapper itself. This allows users to navigate the gallery with arrow keys immediately when the node is focused/selected.
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Do not replace `&&=` or `||=` with `=` when there is no reason to do so. If you do find a reason to remove either `&&=` or `||=`, leave a comment explaining why the removal occurred
Applied to files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vue
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).
Applied to files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.ts
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LiteGraphGlobal.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vue
📚 Learning: 2025-12-11T03:55:51.755Z
Learnt from: simula-r
Repo: Comfy-Org/ComfyUI_frontend PR: 7252
File: src/renderer/extensions/vueNodes/components/ImagePreview.vue:151-158
Timestamp: 2025-12-11T03:55:51.755Z
Learning: In Vue components under src/renderer/extensions/vueNodes (e.g., ImagePreview.vue and LGraphNode.vue), implement image gallery keyboard navigation so that it responds to the node's focus state rather than requiring focus inside the image preview wrapper. Achieve this by wiring keyEvent handling at the node focus level and injecting or propagating key events (arrow keys) to the gallery when the node is focused/selected. This improves accessibility and aligns navigation with node-level focus behavior.
Applied to files:
src/renderer/extensions/vueNodes/components/LGraphNode.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/renderer/extensions/vueNodes/components/LGraphNode.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/renderer/extensions/vueNodes/components/LGraphNode.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/renderer/extensions/vueNodes/components/LGraphNode.vue
📚 Learning: 2025-12-22T21:36:08.369Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.
Applied to files:
src/renderer/extensions/vueNodes/components/LGraphNode.vue
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/renderer/extensions/vueNodes/components/LGraphNode.vue
📚 Learning: 2025-12-18T21:15:46.862Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.
Applied to files:
src/renderer/extensions/vueNodes/components/LGraphNode.vue
📚 Learning: 2025-12-21T01:06:02.786Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.
Applied to files:
src/renderer/extensions/vueNodes/components/LGraphNode.vue
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: lint-and-format
- GitHub Check: setup
- GitHub Check: test
- GitHub Check: collect
🔇 Additional comments (2)
src/lib/litegraph/src/LiteGraphGlobal.ts (1)
63-63: Bypass color constant change aligns with overlay-based visualsUpdating
NODE_DEFAULT_BYPASS_COLORto'#6a246a'is a safe, localized change and matches the shift to a color-only bypass indicator. No behavioral or API concerns from this file alone.src/lib/litegraph/src/LGraphCanvas.ts (1)
5777-5782: Bypass no longer affects node alpha; confirm intent for NEVER mode
getNodeModeAlphanow only special-casesLGraphEventMode.NEVER(alpha0.4), usingeditor_alphafor all other modes, including BYPASS. This cleanly stops bypassed nodes from becoming translucent and exposing links underneath, consistent with the PR goal of hiding links under bypassed nodes.One behavioral note: nodes in NEVER mode remain semi‑transparent, so connections beneath them will still be partially visible. If the expectation from issue #7755 is that all nodes (not just bypassed ones) should fully occlude links, you may want to revisit whether NEVER nodes should also render at full alpha.
| // Note: We no longer reduce opacity for bypassed/muted nodes. | ||
| // Using only the color overlay (before:bg-bypass/60) ensures links | ||
| // remain hidden underneath the node instead of showing through. | ||
| return globalOpacity |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n src/renderer/extensions/vueNodes/components/LGraphNode.vue | head -80Repository: Comfy-Org/ComfyUI_frontend
Length of output: 3186
🏁 Script executed:
cat -n src/renderer/extensions/vueNodes/components/LGraphNode.vue | tail -200Repository: Comfy-Org/ComfyUI_frontend
Length of output: 7250
🏁 Script executed:
rg -n --type=css -C2 'bypass|muted' src/ --max-count=20Repository: Comfy-Org/ComfyUI_frontend
Length of output: 420
🏁 Script executed:
# Find nodeOpacity computed property around line 246
sed -n '240,260p' src/renderer/extensions/vueNodes/components/LGraphNode.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 927
🏁 Script executed:
# Search for theme/Tailwind color definitions for bypass and muted
find src -name "*.css" -o -name "*.ts" -o -name "tailwind*" | head -20Repository: Comfy-Org/ComfyUI_frontend
Length of output: 867
🏁 Script executed:
# Look for style.css or theme configuration files
fd -e css style -t f src/Repository: Comfy-Org/ComfyUI_frontend
Length of output: 94
🏁 Script executed:
# Search for bypass and muted color definitions in style.css
cat src/assets/css/style.css | grep -i -A2 -B2 'bypass\|muted'Repository: Comfy-Org/ComfyUI_frontend
Length of output: 52
🏁 Script executed:
# Search for Tailwind configuration and color definitions
fd tailwind -t f src/ -o -name "*.config.*" -o -name "theme*"Repository: Comfy-Org/ComfyUI_frontend
Length of output: 300
🏁 Script executed:
# Search CSS variables in style.css for bypass and muted
rg --type=css 'bypass|muted|--bg-' src/assets/css/style.css | head -30Repository: Comfy-Org/ComfyUI_frontend
Length of output: 52
🏁 Script executed:
# Read the entire style.css to check for color definitions
wc -l src/assets/css/style.cssRepository: Comfy-Org/ComfyUI_frontend
Length of output: 96
🏁 Script executed:
# Search for CSS variable definitions more broadly
cat src/assets/css/style.css | head -200Repository: Comfy-Org/ComfyUI_frontend
Length of output: 118
🏁 Script executed:
# Find all color-related definitions in CSS
rg 'bg-bypass|bg-muted|bypass|muted' --type=css -iRepository: Comfy-Org/ComfyUI_frontend
Length of output: 1067
🏁 Script executed:
# Check Tailwind configuration for color mappings
find . -name "tailwind.config.*" -o -name "tailwind.config.ts" | head -5Repository: Comfy-Org/ComfyUI_frontend
Length of output: 134
🏁 Script executed:
# Search for Tailwind config files in the repository
fd "tailwind.config" -t fRepository: Comfy-Org/ComfyUI_frontend
Length of output: 130
🏁 Script executed:
# Look for how Tailwind colors are configured
rg "extend.*colors|bg-bypass|bg-muted" --type=ts --type=jsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 976
🏁 Script executed:
# Read the main Tailwind config
cat tailwind.config.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 233
🏁 Script executed:
# Read the design-system Tailwind config
cat packages/design-system/tailwind.config.ts | head -100Repository: Comfy-Org/ComfyUI_frontend
Length of output: 563
🏁 Script executed:
# Check the bypass test to understand how muted nodes should work
cat browser_tests/tests/vueNodes/nodeStates/bypass.spec.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 2008
🏁 Script executed:
# Search for muted node state handling in tests
find browser_tests -name "*.spec.ts" -o -name "*.test.ts" | xargs grep -l "muted" 2>/dev/nullRepository: Comfy-Org/ComfyUI_frontend
Length of output: 160
🏁 Script executed:
# Check if bg-muted is actually used anywhere in the codebase
rg "bg-muted[^-]" --type=vue --type=tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 97
🏁 Script executed:
# Look for how muted nodes were handled in git history or old code
rg "nodeOpacity|muted.*opacity" --type=ts --type=vue -B5 -A5Repository: Comfy-Org/ComfyUI_frontend
Length of output: 97
🏁 Script executed:
# Check if there's a muted state in nodeData
rg "nodeData\.muted|\.muted" src/renderer/extensions/vueNodes/ --type=ts --type=vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 97
🏁 Script executed:
# Check the muted node state test
cat browser_tests/tests/vueNodes/nodeStates/mute.spec.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 1798
🏁 Script executed:
# Search for muted nodes in the codebase
rg "muted" src/renderer/extensions/vueNodes/ -A2 -B2Repository: Comfy-Org/ComfyUI_frontend
Length of output: 6678
🏁 Script executed:
# Look for the muted property definition
rg "\.muted\s*=" src/renderer/extensions/vueNodes/components/LGraphNode.vue -B3 -A3Repository: Comfy-Org/ComfyUI_frontend
Length of output: 52
🏁 Script executed:
# Check if there's visual distinction setup for muted nodes anywhere
rg "muted.*class\|muted.*before\|muted.*overlay" src/renderer/extensions/vueNodes/ -iRepository: Comfy-Org/ComfyUI_frontend
Length of output: 52
🏁 Script executed:
# Check if bg-muted is defined in design-system CSS
grep -r "bg-muted\|color-muted" packages/design-system/src/css/ 2>/dev/nullRepository: Comfy-Org/ComfyUI_frontend
Length of output: 568
🏁 Script executed:
# Look for the LGraphEventMode to understand the muted state
rg "LGraphEventMode" src/ -B2 -A8Repository: Comfy-Org/ComfyUI_frontend
Length of output: 48889
🏁 Script executed:
# Check if tests are currently passing or if this change broke them
rg "MUTE_OPACITY\|mute.spec" browser_tests/ -lRepository: Comfy-Org/ComfyUI_frontend
Length of output: 52
🏁 Script executed:
# Check what the LGraphCanvas code shows for muted node opacity handling
grep -n "LGraphEventMode.NEVER\|0.4\|0.5" src/lib/litegraph/src/LGraphCanvas.ts -B2 -A2Repository: Comfy-Org/ComfyUI_frontend
Length of output: 6281
🏁 Script executed:
# Search for any bg-muted color definition
rg "bg-muted|--muted" packages/design-system/ --type=cssRepository: Comfy-Org/ComfyUI_frontend
Length of output: 611
🏁 Script executed:
# Verify if there's a separate Tailwind config for colors
cat packages/design-system/src/css/style.css | head -100Repository: Comfy-Org/ComfyUI_frontend
Length of output: 2394
🏁 Script executed:
# Final verification: check if the mute test is expected to fail or if this is intentional
git log --oneline -5 browser_tests/tests/vueNodes/nodeStates/mute.spec.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 122
🏁 Script executed:
# Check if there's any recent commit that changed nodeOpacity
git log --oneline -10 src/renderer/extensions/vueNodes/components/LGraphNode.vue | head -20Repository: Comfy-Org/ComfyUI_frontend
Length of output: 122
🏁 Script executed:
# Check the full commit to understand the intent
git show b5d528c8 --statRepository: Comfy-Org/ComfyUI_frontend
Length of output: 50383
🏁 Script executed:
# See the exact changes to the mute test
git show b5d528c8 -- browser_tests/tests/vueNodes/nodeStates/mute.spec.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 2279
Critical: Muted nodes lose visual distinction and break the mute test.
The nodeOpacity computed property at lines 246-249 removes opacity reduction for muted nodes entirely. However, the mute test added in this same commit (browser_tests/tests/vueNodes/nodeStates/mute.spec.ts) explicitly expects muted nodes to have opacity: 0.5. This mismatch will cause test failures.
Additionally, muted nodes at lines 27-28 receive no color overlay (unlike bypassed nodes at line 25 which get before:bg-bypass/60), leaving them with no visual indication now that opacity reduction is removed.
Add a visual indicator for muted nodes—either restore opacity reduction for muted state or add a color overlay like bypassed nodes. The theme color --color-bypass is defined but bg-muted is not available as a Tailwind class; use the existing CSS variable --muted-background instead.
🤖 Prompt for AI Agents
In src/renderer/extensions/vueNodes/components/LGraphNode.vue around lines
246-249 and the node class logic at lines ~25-28, the nodeOpacity computed
removed the 0.5 opacity for muted nodes and muted nodes also lack a color
overlay; change nodeOpacity to return globalOpacity * 0.5 when the node is muted
(so muted nodes have opacity: 0.5 under default globalOpacity), and add a muted
color overlay similar to bypassed nodes by applying a before
pseudo-element/background that uses the CSS variable --muted-background (e.g.
mirror the before:bg-bypass/60 approach but reference var(--muted-background)
with appropriate opacity) so muted nodes regain a visual indicator and tests
expecting opacity: 0.5 pass.
jtydhr88
added
the
New Browser Test Expectations
|
Updating Playwright Expectations |
|
What problem is this solving? |
|
@PabloWiedemann Normally, the line is under the node. |
Summary
(Not sure we want it, but try to fix #7755 which makes sense to me)
Remove opacity reduction for bypassed nodes so that links remain hidden underneath instead of showing through. The bypass visual is now indicated only by the color overlay.
Screenshots - litegraph
before
after
Screenshots - vueNodes
before
after
┆Issue is synchronized with this Notion page by Unito