Skip to content

fix: restore bypass/mute visual effect on preview images #7790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
godwiniheuwa wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: restore bypass/mute visual effect on preview images #7790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d1d044
fix: restore bypass/mute visual effect on preview images
RUiNtheExtinct Dec 28, 2025
7b45ad0
refactor: use cn() utility for class binding in preview components
RUiNtheExtinct Dec 28, 2025
e9aba7b
style(VideoPreview): use object syntax in cn() for consistency
RUiNtheExtinct Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/renderer/extensions/vueNodes/VideoPreview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,12 @@
<video
v-if="!videoError"
:src="currentVideoUrl"
:class="cn('block size-full object-contain', showLoader && 'invisible')"
:class="
cn('block size-full object-contain', {
invisible: showLoader,
'opacity-50 grayscale': props.inactive
})
"
controls
loop
playsinline
Expand Down Expand Up @@ -126,6 +131,8 @@ interface VideoPreviewProps {
readonly imageUrls: readonly string[] // Named imageUrls for consistency with parent components
/** Optional node ID for context-aware actions */
readonly nodeId?: string
/** Whether the node is bypassed or muted */
readonly inactive?: boolean
}

const props = defineProps<VideoPreviewProps>()
Expand Down
9 changes: 8 additions & 1 deletion src/renderer/extensions/vueNodes/components/ImagePreview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@
ref="currentImageEl"
:src="currentImageUrl"
:alt="imageAltText"
class="block size-full object-contain pointer-events-none"
:class="
cn('block size-full object-contain pointer-events-none', {
'opacity-50 grayscale': props.inactive
})
"
@load="handleImageLoad"
@error="handleImageError"
/>
Expand Down Expand Up @@ -128,12 +132,15 @@ import { downloadFile } from '@/base/common/downloadUtil'
import { app } from '@/scripts/app'
import { useCommandStore } from '@/stores/commandStore'
import { useNodeOutputStore } from '@/stores/imagePreviewStore'
import { cn } from '@/utils/tailwindUtil'

interface ImagePreviewProps {
/** Array of image URLs to display */
readonly imageUrls: readonly string[]
/** Optional node ID for context-aware actions */
readonly nodeId?: string
/** Whether the node is bypassed or muted */
readonly inactive?: boolean
}

const props = defineProps<ImagePreviewProps>()
Expand Down
11 changes: 9 additions & 2 deletions src/renderer/extensions/vueNodes/components/LGraphNode.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,18 @@
<NodeWidgets v-if="nodeData.widgets?.length" :node-data="nodeData" />

<div v-if="hasCustomContent" class="min-h-0 flex-1 flex">
<NodeContent :node-data="nodeData" :media="nodeMedia" />
<NodeContent
:node-data="nodeData"
:media="nodeMedia"
:inactive="bypassed || muted"
/>
</div>
<!-- Live mid-execution preview images -->
<div v-if="shouldShowPreviewImg" class="min-h-0 flex-1 px-4">
<LivePreview :image-url="latestPreviewUrl || null" />
<LivePreview
:image-url="latestPreviewUrl || null"
:inactive="bypassed || muted"
/>
</div>
</div>
</template>
Expand Down
10 changes: 9 additions & 1 deletion src/renderer/extensions/vueNodes/components/LivePreview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@
v-else
:src="imageUrl"
:alt="$t('g.liveSamplingPreview')"
class="pointer-events-none h-full w-full object-contain object-center"
:class="
cn('pointer-events-none h-full w-full object-contain object-center', {
'opacity-50 grayscale': props.inactive
})
"
@load="handleImageLoad"
@error="handleImageError"
/>
Expand All @@ -38,9 +42,13 @@
<script setup lang="ts">
import { ref, watch } from 'vue'

import { cn } from '@/utils/tailwindUtil'

interface LivePreviewProps {
/** Image URL to display */
imageUrl: string | null
/** Whether the node is bypassed or muted */
inactive?: boolean
}

const props = defineProps<LivePreviewProps>()
Expand Down
4 changes: 4 additions & 0 deletions src/renderer/extensions/vueNodes/components/NodeContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,14 @@
v-if="hasMedia && media?.type === 'video'"
:image-urls="media.urls"
:node-id="nodeId"
:inactive="props.inactive"
class="mt-2"
/>
<ImagePreview
v-else-if="hasMedia && media?.type === 'image'"
:image-urls="media.urls"
:node-id="nodeId"
:inactive="props.inactive"
class="mt-2"
/>
</slot>
Expand All @@ -37,6 +39,8 @@ interface NodeContentProps {
type: 'image' | 'video'
urls: string[]
}
/** Whether the node is bypassed or muted */
inactive?: boolean
}

const props = defineProps<NodeContentProps>()
Expand Down