i18n: Update zh locale #7787
Merged
i18n: Update zh locale #7787
+8,337
−6,465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorotaLuna
requested review from
a team,
KarryCharon,
Yorha4D and
shinshin86
as code owners
dosubot
bot
added
the
size:M
Contributor
📝 WalkthroughWalkthroughUpdates Chinese locale files: adds two new translation keys and tooltip/option metadata in settings, and removes duplicate entries in the commands file. No functional code changes. Changes
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status
⏰ Started at: 01/04/2026, 03:02:34 AM UTC 🚀 Building Storybook
⏱️ Please wait while the Storybook build is in progress... |
🎭 Playwright Test Results⏰ Completed at: 01/04/2026, 03:21:44 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Member
|
This PR changes the ordering of many keys but does not update the translation, which makes the review difficult. I have created a tool here, reviewing now 
|
Member
|
The main changes in this PR are adding many missing nodeDef translations. All LGTM. More deatils settings.jsonThere are no translation updates. 
main.jsonAdded 3 new translations, all LGTM 
nodeDefs.jsonAdded 649 new keys. All new values seem good. 
commands.jsonThere are no translation updates. 
|
Member
|
@DorotaLuna, this branch is outdated. Can you update it and solve the conflict? |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.21 MB (baseline 3.21 MB) • ⚪ 0 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 1000 kB (baseline 1000 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.63 kB (baseline 6.63 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 300 kB (baseline 300 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 7 added / 7 removed UI Components — 199 kB (baseline 199 kB) • ⚪ 0 BReusable component library chunks
Status: 9 added / 9 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 9.12 MB (baseline 9.12 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.5 MB (baseline 3.47 MB) • 🔴 +33.1 kBBundles that do not match a named category
Status: 23 added / 23 removed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
src/locales/zh/commands.jsonsrc/locales/zh/main.jsonsrc/locales/zh/nodeDefs.jsonsrc/locales/zh/settings.json
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,vue,js,jsx,json,css}
📄 CodeRabbit inference engine (AGENTS.md)
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, and 80-character line width
Files:
src/locales/zh/commands.jsonsrc/locales/zh/settings.json
🧠 Learnings (2)
📓 Common learnings
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/locales/en/main.json:774-780
Timestamp: 2025-12-09T04:35:43.971Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, locale files other than `src/locales/en/main.json` are generated automatically on every release. Developers only need to add English (en) key/values in `src/locales/en/main.json` when making PRs; manual updates to other locale files (fr, ja, ko, ru, zh, zh-TW, es, ar, tr, etc.) are not required and should not be suggested in reviews.
📚 Learning: 2025-12-09T04:35:43.971Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/locales/en/main.json:774-780
Timestamp: 2025-12-09T04:35:43.971Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, locale files other than `src/locales/en/main.json` are generated automatically on every release. Developers only need to add English (en) key/values in `src/locales/en/main.json` when making PRs; manual updates to other locale files (fr, ja, ko, ru, zh, zh-TW, es, ar, tr, etc.) are not required and should not be suggested in reviews.
Applied to files:
src/locales/zh/commands.jsonsrc/locales/zh/settings.json
🔇 Additional comments (7)
src/locales/zh/commands.json (2)
83-85: LGTM!The new translation for
Comfy_Canvas_ToggleSelected_Pinis appropriate. The distinction between this ("选中项" - selected items) and the existingComfy_Canvas_ToggleSelectedNodes_Pin("选中节点" - selected nodes) at lines 95-97 is correctly maintained.
293-295: LGTM!The translation "显示快捷键对话框" (Show shortcuts dialog) is accurate and consistent with the naming convention.
src/locales/zh/settings.json (5)
20-26: LGTM!The WindowStyle tooltip and options are properly translated and well-formatted.
82-91: LGTM!The PreviewMethod tooltip enhancement and option translations are clear and accurate.
160-166: LGTM!The CameraType tooltip provides helpful context about the default camera behavior for 3D widgets.
184-191: LGTM!The PLYEngine tooltip clearly explains the different engine options and their use cases.
391-397: LGTM!The WidgetControlMode tooltip and options are appropriately translated.
Comment on lines
+374
to
+378
| "tooltip": "选单列位置。在行动装置上，选单始终显示于顶端。", | ||
| "options": { | ||
| "Disabled": "禁用", | ||
| "Top": "顶部" | ||
| }, | ||
| "tooltip": "选单列位置。在行动装置上，选单始终显示于顶端。" | ||
| } |
Contributor
There was a problem hiding this comment.
Inconsistent use of Traditional Chinese terms in Simplified Chinese locale.
This tooltip uses Traditional Chinese terminology ("选单", "行动装置") which is inconsistent with the rest of the file that uses Simplified Chinese (e.g., "菜单" on line 373).
🔎 Suggested fix
- "tooltip": "选单列位置。在行动装置上，选单始终显示于顶端。",
+ "tooltip": "菜单栏位置。在移动设备上，菜单始终显示在顶部。",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "tooltip": "选单列位置。在行动装置上，选单始终显示于顶端。", | |
| "options": { | |
| "Disabled": "禁用", | |
| "Top": "顶部" | |
| }, | |
| "tooltip": "选单列位置。在行动装置上，选单始终显示于顶端。" | |
| } | |
| "tooltip": "菜单栏位置。在移动设备上，菜单始终显示在顶部。", | |
| "options": { | |
| "Disabled": "禁用", | |
| "Top": "顶部" | |
| } |
🤖 Prompt for AI Agents
In src/locales/zh/settings.json around lines 374-378, the tooltip uses
Traditional Chinese terms ("选单", "行动装置") inconsistent with the file's Simplified
Chinese; update the tooltip to use Simplified equivalents by replacing "选单" with
"菜单" and "行动装置" with "移动设备" so the tooltip reads consistently (e.g.,
"菜单列位置。在移动设备上，菜单始终显示于顶部。").
Contributor
Author
|
Should solved now, sorry for not familiar with git commnads. @comfyui-wiki |
Member
|
@DorotaLuna Thanks for the contribution. |
christian-byrne
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reorder keys in json, align with english version (line to line), to make proofreading and supplementary easily.
Supplement untranslated content in nodeDefs.
Changes
zh Locale changes.
┆Issue is synchronized with this Notion page by Unito