Skip to content

Add brush hardness commands and default keybindings for Mask Editor #7770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Koudkunstje wants to merge 12 commits into
base: main
Choose a base branch
from
+400 −57
Open

Add brush hardness commands and default keybindings for Mask Editor #7770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
76b13de
Add brush hardness commands and default keybindings for Mask Editor
Koudkunstje Dec 27, 2025
9edec5c
Merge branch 'main' into brush-hardness-keybinding
Koudkunstje Dec 28, 2025
c654301
Merge branch 'main' into brush-hardness-keybinding
Koudkunstje Dec 31, 2025
2a62aa5
Merge branch 'main' into brush-hardness-keybinding
Koudkunstje Jan 5, 2026
d115011
Merge branch 'main' into brush-hardness-keybinding
Koudkunstje Jan 5, 2026
3c4f6ab
Merge branch 'Comfy-Org:main' into brush-hardness-keybinding
Koudkunstje Jan 5, 2026
438cd9f
Adjust brush size decrease step in MaskEditor
Koudkunstje Jan 5, 2026
c3af82d
Remove brush size adjustment function
Koudkunstje Jan 5, 2026
39745e8
Merge branch 'Comfy-Org:main' into brush-hardness-keybinding
Koudkunstje Jan 5, 2026
d5a8765
Merge branch 'Comfy-Org:main' into brush-hardness-keybinding
Koudkunstje Jan 6, 2026
ac9b960
Remove hardcoded keybindings from mask editor extension
Koudkunstje Jan 6, 2026
61caac8
Merge branch 'main' into brush-hardness-keybinding
Koudkunstje Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@
"@storybook/addon-docs": "catalog:",
"@storybook/vue3": "catalog:",
"@storybook/vue3-vite": "catalog:",
"@swc-node/register": "catalog:",
"@swc/core": "catalog:",
Comment on lines +71 to +72
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# First, let's check the package.json to see the exact dependencies added
echo "=== Checking package.json around the flagged lines ==="
sed -n '65,80p' package.json
echo ""
sed -n '110,120p' package.json

echo -e "\n=== Searching for @swc-node/register usage ==="
rg '@swc-node/register|swc-node/register' -C2

echo -e "\n=== Searching for @swc/core usage ==="
rg '@swc/core|from.*swc' -C2

echo -e "\n=== Searching for ts-node usage ==="
rg 'ts-node' -C2

echo -e "\n=== Checking for tsconfig for ts-node ==="
find . -maxdepth 1 -name "tsconfig*.json" -exec cat {} \;

echo -e "\n=== Checking build and dev scripts in package.json ==="
rg '"(build|dev|test|start|scripts)"' package.json -A 10

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 50382

🏁 Script executed:

#!/bin/bash

# Check if ts-node is referenced anywhere in the project's build/test setup
echo "=== Checking for ts-node in tsconfig or build configs ==="
rg -l 'ts-node' --type-list | head -20
rg 'ts-node' tsconfig.json .storybook .nx

# Check if @swc-node/register is used in any config files
echo -e "\n=== Checking swc configuration usage ==="
find . -maxdepth 2 -name '.swcrc*' -o -name 'swc.config.*'

# Get summary of what Nx packages depend on these
echo -e "\n=== Checking which Nx tools have swc/ts-node dependencies ==="
grep -A5 '@nx/eslint\|@nx/vite\|@nx/vitest' pnpm-workspace.yaml | head -20

# Check if there are any npm scripts that use ts-node
echo -e "\n=== Checking scripts in package.json ==="
sed -n '/"scripts"/,/^  }/p' package.json | head -30

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 2922

Clarify why dev dependencies were added despite the PR description stating "no new dependencies".

The three packages @swc-node/register, @swc/core, and ts-node have been added to devDependencies, but the PR description claims "no new dependencies." While these are peer dependencies of existing Nx tools (not arbitrary additions), this contradicts the stated constraint. Either the PR description should be updated to reflect these additions, or clarify if their inclusion is intentional.

🤖 Prompt for AI Agents 
In @package.json around lines 71 - 72, The PR claims "no new dependencies" but
devDependencies now include "@swc-node/register", "@swc/core", and "ts-node";
either update the PR description to state that these devDependencies were added
(and note they are peer deps required by existing Nx tooling), or remove them if
they were added unintentionally; locate the devDependencies block and the PR
text referencing "no new dependencies" and ensure the description accurately
reflects the inclusion of "@swc-node/register", "@swc/core", and "ts-node" (or
revert those entries) and add a short rationale that they are peer dependencies
of existing tools if keeping them.

Copy link
Author

@Koudkunstje Koudkunstje Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fotgot about this. After adressing all the issues, I wanted to test the changes with pnpm dev, but I ran into a problem and this seemed to fix it. I revert the files back to their original state, once I get back home.

Copy link
Author

@Koudkunstje Koudkunstje Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fotgot about this. After adressing all the issues, I wanted to test the changes with pnpm dev, but I ran into a problem and this seemed to fix it. I revert the files back to their original state, once I get back home.

Copy link
Contributor

@coderabbitai coderabbitai bot Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Koudkunstje, thanks for the clarification! Yes, reverting those dependency changes makes sense since they're not related to the brush hardness feature. The PR should stay focused on just the mask editor commands.

If you continue to run into issues with pnpm dev after reverting, feel free to mention what error you encountered—it might be something we can help troubleshoot or it could indicate an environment setup issue unrelated to your changes.

🧠 Learnings used 
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-16T17:41:58.464Z
Learning: Prerequisites for repository setup: Node.js >= 24, Git repository, available ports for dev server and storybook

Copy link
Contributor

@coderabbitai coderabbitai bot Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Koudkunstje, thanks for clarifying! Reverting those dependency changes makes sense since the PR is focused on the brush hardness feature.

If you continue to encounter issues with pnpm dev after reverting, feel free to mention it and I can help investigate what might be causing the problem. It's possible there's a different underlying issue that needs to be addressed separately.

🧠 Learnings used 
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-16T17:41:58.464Z
Learning: Prerequisites for repository setup: Node.js >= 24, Git repository, available ports for dev server and storybook

"@tailwindcss/vite": "catalog:",
"@trivago/prettier-plugin-sort-imports": "catalog:",
"@types/fs-extra": "catalog:",
Expand Down Expand Up @@ -111,6 +113,7 @@
"stylelint": "catalog:",
"tailwindcss": "catalog:",
"tailwindcss-primeui": "catalog:",
"ts-node": "catalog:",
"tsx": "catalog:",
"tw-animate-css": "catalog:",
"typescript": "catalog:",
Expand Down
Loading