Skip to content

Correct parsing segmentation duration with 40 bits. #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
potterxu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct parsing segmentation duration with 40 bits. #178

potterxu wants to merge 1 commit into from

Conversation

@potterxu
Copy link

@potterxu potterxu commented May 28, 2024

This pull request is fixing bug raised in [#100] by changing the uint40() function to get the value of the full 5-bytes slice.

The other usage of uint40() function already use 33 bits mask to truncate the value.
scte35.go:113
splicecommand.go:221
splicecommand.go:325

@CLAassistant
Copy link

CLAassistant commented May 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@potterxu @CLAassistant