Skip to content

[Fix] Insignia issues#312

Merged
empollak merged 7 commits intodevelopfrom
bugfix/insignia-issues
Feb 24, 2026
Merged

[Fix] Insignia issues#312
empollak merged 7 commits intodevelopfrom
bugfix/insignia-issues

Conversation

@empollak
Copy link
Copy Markdown
Collaborator

@empollak empollak commented Feb 14, 2026 •
edited
Loading

Pull Request Description

When merged this pull request will:

  • Reapply insignia any time the player has the wrong one, not just any time their uniform/group/etc. changes
  • Make the check for uniform insignia support case-insensitive
  • Add an event handler to apply insignia any time the uniform is changed
  • Fix locality so that JIP players always get insignias

Release Notes

Fixes various bugs to make insignias apply more consistently.

IMPORTANT

  • Testing has been completed as neccessary, depending on the nature & impact of the changes.
  • The Release Notes section below must be filled out appropriately to explain the changes made in this PR. This section will be used in Framework Changelogs.
  • If the contribution affects the wiki, please include your changes in this pull request so the wiki is consistently updated.
  • Contribution Guidelines are read, understood and applied.
  • Title of this PR uses our standard template [Descriptor] - Add|Fix|Improve|Change|Make|Remove {changes}.

@empollak
Local insignia fixes
891b06c 
Insignia monitor runs on vest and backpack change, and apply insignia uses updated group
@empollak
Apply insignia whenever gearscript runs
6438474
Bubbus
Bubbus previously approved these changes Feb 14, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Bubbus Bubbus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I don't understand the checks on the vest and backpack. let's go though

edit: nvm i just checked discord lol

@empollak
Copy link
Copy Markdown
Collaborator Author

empollak commented Feb 14, 2026

I realized I have more testing to do, please hold

@github-actions github-actions bot requested a review from Bubbus February 14, 2026 23:34
Bubbus
Bubbus previously approved these changes Feb 15, 2026
View reviewed changes
@empollak
Detect incorrect insignia instead of changed
885d4d0 
This gets rid of all the edge cases around timing, ACE arsenal changing your insignia when your vest/backpack changes, and any other edge case that could crop up. It does mean that we have to figure out the correct insignia every 5 seconds, but that's not very much work.
@empollak
Add event handler for uniform change
d9e07ab 
Adds an event handler to instantly update the insignia when the uniform changes. Makes behavior much snappier in ACE arsenal. Adds performance hit of one if statement every time a piece of your loadout changes. Not bad.
@empollak empollak marked this pull request as draft February 15, 2026 00:44
@empollak empollak marked this pull request as ready for review February 15, 2026 17:29
@github-actions github-actions bot requested a review from Bubbus February 15, 2026 18:59
@empollak
Copy link
Copy Markdown
Collaborator Author

empollak commented Feb 15, 2026

still in discussions around the default

@empollak empollak merged commit 3bf1474 into develop Feb 24, 2026
1 check passed
@empollak empollak deleted the bugfix/insignia-issues branch February 24, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bubbus Bubbus Bubbus approved these changes

@Cre8or Cre8or Awaiting requested review from Cre8or

@dgibso29 dgibso29 Awaiting requested review from dgibso29

@Joecuronium Joecuronium Awaiting requested review from Joecuronium

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@empollak @Bubbus