Merged
Conversation
- `UIComponent`:
- Added private `_subComponent` flag to distinguish subcomponents.
- Refactored constructors:
- Added private named constructor `UIComponent._` to centralize initialization.
- Added public mirror constructor `UIComponent` with detailed documentation on parameters controlling rendering, styling, and structure.
- Added new constructor `UIComponent.subComponent` for creating components attached to an existing `parentComponent`, sharing its DOM mapping context.
- Updated `dispose` method to avoid disposing shared `domTreeMap` when the component is a subcomponent.
- `UIButton` (`button.dart`):
- Extended `$uiButtonLoader` function to support additional attributes for loaded text styling and content:
- Added parameters: `loadedTextClass`, `loadedTextStyle`, `loadedTextErrorClass`, `loadedTextErrorStyle`, `loadedTextOK`, `loadedTextError`.
- Added corresponding attributes to the returned DOM element for these new parameters.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
=======================================
Coverage 38.08% 38.08%
=======================================
Files 23 23
Lines 3421 3421
=======================================
Hits 1303 1303
Misses 2118 2118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UIComponent:_subComponentflag to distinguish subcomponents.UIComponent._to centralize initialization.UIComponentwith detailed documentation on parameters controlling rendering, styling, and structure.UIComponent.subComponentfor creating components attached to an existingparentComponent, sharing its DOM mapping context.disposemethod to avoid disposing shareddomTreeMapwhen the component is a subcomponent.UIButton(button.dart):$uiButtonLoaderfunction to support additional attributes for loaded text styling and content:loadedTextClass,loadedTextStyle,loadedTextErrorClass,loadedTextErrorStyle,loadedTextOK,loadedTextError.