v1.9.26 - Fix - Initializable: improve error handling#141
Merged
Conversation
- `Initializable` mixin:
- `ensureInitialized`: added `onError` handler to `then` call to route errors to `_onInitializationError`.
- `executeInitializedCallback`:
- Added `onError` handler to `then` call on async initialization result to throw `InitializationError` with stack trace.
- `_FutureExtension`:
- `toCompleter`: added `onError` handler to `then` to complete completer with error and stack trace if not completed.
gmpassos
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 65.35% 65.45% +0.09%
==========================================
Files 62 62
Lines 21164 21173 +9
==========================================
+ Hits 13831 13858 +27
+ Misses 7333 7315 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initializablemixin:ensureInitialized: addedonErrorhandler tothencall to route errors to_onInitializationError.executeInitializedCallback:onErrorhandler tothencall on async initialization result to throwInitializationErrorwith stack trace._FutureExtension:toCompleter: addedonErrorhandler tothento complete completer with error and stack trace if not completed.