Fix detector_frame_to_source_frame to use passed parameters instead of nonexistent self.parameters #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 97 in
cosmo_models.pyreferencesself.parameterswhich doesn't exist, causing failures when using parametrized cosmologies (FlatwCDM, FlatLambdaCDM). The method signature accepts**parametersbut wasn't using them.Changes
self.cosmology(self.parameters)→self.cosmology(parameters)Impact
Before this fix, calling
detector_frame_to_source_framewith FlatwCDM or FlatLambdaCDM would fail:Now works correctly with passed parameters used for cosmology calculations.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.