Skip to content

Conversation

@asb5468
Copy link
Contributor

@asb5468 asb5468 commented Oct 17, 2024

Adds a likelihood that can be used to sample from the prior subject to the constraint set by the maximum_uncertainty

@ColmTalbot
Copy link
Owner

Thanks @asb5468! Can you add a simple test to test/likelihood_test.py? Just so that this is used as part of the CI in case I make a breaking change down the line?

@ColmTalbot ColmTalbot requested a review from Copilot November 19, 2024 19:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.42%. Comparing base (0cb3ceb) to head (75d1db2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
gwpopulation/hyperpe.py 50.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   88.59%   88.42%   -0.17%     
==========================================
  Files          14       14              
  Lines         903      907       +4     
==========================================
+ Hits          800      802       +2     
- Misses        103      105       +2     
Flag Coverage Δ
python3.10 88.42% <50.00%> (-0.17%) ⬇️
python3.11 88.42% <50.00%> (-0.17%) ⬇️
python3.12 88.42% <50.00%> (-0.17%) ⬇️
python3.13 88.42% <50.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ColmTalbot
Copy link
Owner

I fixed some merge conflicts and the pre-commits seem to be broken. I'm not sure why.

@ColmTalbot
Copy link
Owner

I fixed some merge conflicts and the pre-commits seem to be broken. I'm not sure why.

I think this was because there were two blank lines at the end of the file.

@ColmTalbot
Copy link
Owner

I'm going to merge this and add a test later, thanks @asb5468 and sorry for taking such a long time to deal with it.

@ColmTalbot ColmTalbot merged commit ba7ab69 into ColmTalbot:main Dec 15, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants