Test/application: refactoring mock classes #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saksham-gt
force-pushed
the
test/application
branch
from
aa7a5c6 to
3b75b91
Compare
Codecov Report
@@ Coverage Diff @@
## development #250 +/- ##
==============================================
+ Coverage 7.90% 9.75% +1.84%
==============================================
Files 122 122
Lines 3401 3404 +3
==============================================
+ Hits 269 332 +63
+ Misses 3132 3072 -60
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Co-authored-by: Mathias Mogensen <42929161+Xazin@users.noreply.github.com>
Co-authored-by: Mathias Mogensen <42929161+Xazin@users.noreply.github.com>
saksham-gt
force-pushed
the
test/application
branch
from
d371019 to
354fe58
Compare
obella425
reviewed
Sep 10, 2022
obella425
left a comment
obella425
left a comment
There was a problem hiding this comment.
Just a general comment, could these tests be split to their individual P.Rs instead of lumping them together
Member
|
Merge conflicts - needs rebase |
Xazin
force-pushed
the
development
branch
13 times, most recently
from
5be7e86 to
77ff369
Compare
Xazin
force-pushed
the
development
branch
10 times, most recently
from
05db9fc to
1ac5990
Compare
Member
|
@glitchpop-frenzy 👀 |
Collaborator
Author
|
Noted, will do it this week! 😄 |
Xazin
force-pushed
the
development
branch
2 times, most recently
from
8906c8d to
649893f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaring all mock classes in test utilities.