Fix/spatial navigation scroll bug #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihailTodorov
approved these changes
Apr 7, 2025
Comment on lines
155
to
162
| getElementsDistance(elements) { | ||
| const distances = elements.map((el) => { | ||
| const { x, y } = el.getBoundingClientRect(); | ||
| return Math.hypot(x, y); | ||
| }); | ||
|
|
||
| return Math.max(...distances); | ||
| } |
Contributor
There was a problem hiding this comment.
Can we use reduce here to do the same. It would be something like:
Suggested change
| getElementsDistance(elements) { | |
| const distances = elements.map((el) => { | |
| const { x, y } = el.getBoundingClientRect(); | |
| return Math.hypot(x, y); | |
| }); | |
| return Math.max(...distances); | |
| } | |
| getElementsDistance(elements) { | |
| return elements.reduce((acc, el) => { | |
| const { x, y } = el.getBoundingClientRect(); | |
| const distance = Math.hypot(x, y); | |
| acc = acc < distance ? distance : acc; | |
| }, 0); | |
| } | |
Contributor
Author
There was a problem hiding this comment.
resolved.
alien1976
approved these changes
Apr 7, 2025
Comment on lines
+515
to
+521
| let element; | ||
| for (let i = navigatableElements.length - 1; i >= 0; i--) { | ||
| if (!navigatableElements[i].hasAttribute('disabled')) { | ||
| element = navigatableElements[i]; | ||
| break; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
There is findLast method but we do not support it 😢 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/findLast
Contributor
There was a problem hiding this comment.
Maybe move this in a method for finding the last focused element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
I have concluded that there is no way to accurately calculate the next element in an element that has
scrollWidthorscrollHeightbigger than thewindow.width/height. To get around that I added anoverflowproperty to the navigation area object which will hold the difference between the height of the overflowing element and the viewport. If there isn't it will just be 0.