fix: respect isRegExp option in WorkspaceSearchProvider #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks! |
CGNonofr
approved these changes
Jan 7, 2026
|
🎉 This PR is included in version 24.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #756
I tested it using the demo, seem to work fine
Note:
vscode sets
multilineandunicodealways to true, regardless of the parameters (https://github.com/microsoft/vscode/blob/eba6411f8aee3458c64046b5af0b68ea801fae40/src/vs/workbench/services/search/worker/localFileSearch.ts#L300C10-L300C28). I kept using the parameters here, like the previous implementation. I do not know which is the better approachEdit: I guess this also fixes
isWordMatch