heroku

[8bcb]

No description provided.

[kamildzierzak]

Do we have to remove it because otherwise deploy on heroku doesnt work, or is there another reason? 🤔😁

[8bcb]

I wanted to ask you if thats really necessary cause heroku cannot execute 'npm please-use-yarn' command. I assume its kind of a fake thing? If we need it i will try to find another solution but it was quite hard to find any... Anyway heroku use yarn during the deployment because it detects the yarn lock file

[kamildzierzak]

For me, we can delete it if it casues problems on the heroku. Maybe I will find another way to force use yarn instead of npm, or we just have to remember that we are using yarn 😅

[KonradSzwarc]

Heroku can use yarn instead of npm, so we can preserve those lines. As I remember the only thing you need to do is to replace npm run start:production with yarn start:production

[8bcb]

@KonradSzwarc Yeah, you're right, now it works just fine :)

[8bcb]

Oh, no, I said it too fast, it failed :P

[KonradSzwarc]

Heroku can use yarn instead of npm, so we can preserve those lines. As I remember the only thing you need to do is to replace npm run start:production with yarn start:production

[KonradSzwarc]

I'm not sure if we should have this command.

1. What if someone terminates the dev process and runs it again. Wouldn't Docker try to start the second time?
2. It's kind of asymmetric because Docker starts automatically but needs to be terminated manually.
   I think it could be better if everyone needs to run Docker explicitly from the command line.