-
Notifications
You must be signed in to change notification settings - Fork 67
Update PHP version requirements and test annotations for PHP 8.2 compability #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PHP version requirements and test annotations for PHP 8.2 compability #136
Conversation
tbuczen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, I would say this could be marked at least as an RC version so the package could be used with php >= 8.2 safely
|
@tbuczen i wanted to test it before with the testsuite at my work. |
|
Have tested it without our code and don't see any issues. Please review, if something needs to be done, to move it to the master |
|
Would be nice if this PR can be merged soon so we can use this package also in our PHP8.4 projects. |
|
@TavoNiievez Can you merge this one? |
|
Thanks @TavoNiievez |
|
@bartbrouwer I can only create tag releases with builds in green, and currently there is this error: If you are going to fix it, please take the opportunity to add compatibility with symfony 8.0 and PHP 8.5. |
I will look into that. |
|
@bartbrouwer @TavoNiievez hello, I’ve fixed workflow execution #137 |
This pull request modernizes the codebase by updating PHP and dependency requirements, refactoring for compatibility with newer versions, and improving test coverage and clarity.
These updates ensure the project is compatible with the latest PHP and PHPUnit versions, streamline the codebase, and improve test reliability and maintainability.