Skip to content

Conversation

@demonking
Copy link
Contributor

This pull request modernizes the codebase by updating PHP and dependency requirements, refactoring for compatibility with newer versions, and improving test coverage and clarity.

These updates ensure the project is compatible with the latest PHP and PHPUnit versions, streamline the codebase, and improve test reliability and maintainability.

@demonking demonking marked this pull request as draft September 9, 2025 08:35
Copy link

@tbuczen tbuczen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I would say this could be marked at least as an RC version so the package could be used with php >= 8.2 safely

@demonking demonking marked this pull request as ready for review October 14, 2025 20:55
@demonking demonking marked this pull request as draft October 14, 2025 20:55
@demonking
Copy link
Contributor Author

@tbuczen i wanted to test it before with the testsuite at my work.
the phpunit test's are running flawless, but i want to make a real test 😄

@demonking demonking marked this pull request as ready for review November 4, 2025 10:05
@demonking
Copy link
Contributor Author

Have tested it without our code and don't see any issues.

Please review, if something needs to be done, to move it to the master

@bartbrouwer
Copy link

bartbrouwer commented Nov 10, 2025

Would be nice if this PR can be merged soon so we can use this package also in our PHP8.4 projects.

@bartbrouwer
Copy link

@TavoNiievez Can you merge this one?

@TavoNiievez TavoNiievez merged commit 75e560e into Codeception:master Dec 1, 2025
@bartbrouwer
Copy link

Thanks @TavoNiievez

@TavoNiievez
Copy link
Member

@bartbrouwer I can only create tag releases with builds in green, and currently there is this error:

This request has been automatically failed because it uses a deprecated version of `actions/cache: v2`.
Please update your workflow to use v3/v4 of actions/cache to avoid interruptions.
Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

If you are going to fix it, please take the opportunity to add compatibility with symfony 8.0 and PHP 8.5.

@bartbrouwer
Copy link

@bartbrouwer I can only create tag releases with builds in green, and currently there is this error:


This request has been automatically failed because it uses a deprecated version of `actions/cache: v2`.

Please update your workflow to use v3/v4 of actions/cache to avoid interruptions.

Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

If you are going to fix it, please take the opportunity to add compatibility with symfony 8.0 and PHP 8.5.

I will look into that.

@diamond-cloud
Copy link

@bartbrouwer @TavoNiievez hello, I’ve fixed workflow execution #137
Could you please take a look at this PR when you have time?
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants