This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London-10-shadi-fakhri-JavaScript-Core-1-Coursework-Week4 #223
Open
Shadi38 wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London-10-shadi-fakhri-JavaScript-Core-1-Coursework-Week4 #223Shadi38 wants to merge 1 commit intoCodeYourFuture:mainfrom
Shadi38 wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
llamojha
reviewed
Mar 17, 2023
| */ | ||
| function tidyUpString() { | ||
|
|
||
| function tidyUpString(arr) { |
There was a problem hiding this comment.
Good job with this function. Just a minor comment, try to give more meaningful names to the variables and avoid using keywords like 'array' or 'string' as those can get confused with the type.
| if (password.length < 5) { | ||
| return false; | ||
| } | ||
| if (!containsUppercaseLetter(password)) { |
There was a problem hiding this comment.
You have multiple if statements that will do the same (return false;). How would you optimize this code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.