This repository was archived by the owner on Dec 24, 2025. It is now read-only.
Conversation
- Renamed package from `com.github.codestorm.brick` to `com.github.codestorm.bounceverse.brick` for consistency. - Updated Google Java Format settings to use AOSP style.
thnhmai06
approved these changes
Sep 30, 2025
Member
thnhmai06
left a comment
thnhmai06
left a comment
There was a problem hiding this comment.
Not evaluating the logic or engine compatibility, this commit seems to include the basic properties and methods.
- Attention: Consider whether certain properties should represent “has-a” or “is-a” relationships, and whether some states should be modeled as attributes at all.
- Important: The Javadoc is not complete yet. Please add comprehensive Javadoc for all classes and methods.
| public class Brick { | ||
| private int x, y, width, height; | ||
| private int hp; | ||
| private final int initialHp; |
| private int x, y, width, height; | ||
| private int hp; | ||
| private final int initialHp; | ||
| private boolean destroyed; |
Member
There was a problem hiding this comment.
Should define destroyed as a method (depend on hp)
| @@ -0,0 +1,28 @@ | |||
| package com.github.codestorm.bounceverse.brick; | |||
|
|
|||
| public class PowerBrick extends Brick { | |||
Member
There was a problem hiding this comment.
Should use PowerUp as a attribute of Brick (The "rewards" after broke Brick)
| package com.github.codestorm.bounceverse.brick; | ||
|
|
||
| public class ProtectedBrick extends Brick { | ||
| private String shieldSide; |
Member
There was a problem hiding this comment.
Must using Enum for shieldSide
thnhmai06
approved these changes
Sep 30, 2025
thnhmai06
added a commit
that referenced
this pull request
Oct 27, 2025
* feat: Brick * feat(brick): add PowerBrick and update Brick, ExoplodeBrick, ProtectedBrick * docs(brick): add Javadoc for Brick, ExoplodeBrick, PowerBrick, ProtectedBrick * refactor(brick): remove NormalBrick and StrongBrick * refactor(brick): rename packages and update formatting settings - Renamed package from `com.github.codestorm.brick` to `com.github.codestorm.bounceverse.brick` for consistency. - Updated Google Java Format settings to use AOSP style. --------- Co-authored-by: Mai Thành <62001770+thnhmai06@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.