Backported to 1.20.1 #88
Conversation
VipCoder8
commented
Mar 16, 2025
VipCoder8
commented
- Fixed player inventory keybind issues if sprint set to toggle.
- Backported the excluding undead horses for swimming feature.
- Merged GirlInPurple's changes as they were not present in this branch.
- Fixed player inventory keybind issues if sprint set to toggle - Backported the excluding undead horses for swimming feature - Merged GirlInPurple's changes as they were not present in this branch.
- Fixed player inventory keybind issues if sprint set to toggle - Backported the excluding undead horses for swimming feature - Merged GirlInPurple's changes as they were not present in this branch.
CodeF53
left a comment
CodeF53
left a comment
There was a problem hiding this comment.
Please also update and run the github workflow so I can test the the compiled binary
build.gradle
Outdated
| //modImplementation "net.fabricmc.fabric-api:fabric-api:${project.fabric_version}" | ||
| modImplementation "net.fabricmc.fabric-api:fabric-api:${project.fabric_version}" | ||
| modIncludeImplementation(fabricApi.module("fabric-api-base", project.fabric_version)) | ||
| modIncludeImplementation(fabricApi.module("fabric-rendering-data-attachment-v1", project.fabric_version)) |
There was a problem hiding this comment.
If you are depending on the entire fabric api, you should get rid of its submodules
| assert this.player != null; | ||
| if (MinecraftClient.getInstance().options.sprintKey.isPressed()) { | ||
| boolean leftControl = GLFW.glfwGetKey(MinecraftClient.getInstance().getWindow().getHandle(), GLFW.GLFW_KEY_LEFT_CONTROL) == 1; | ||
| boolean rightControl = GLFW.glfwGetKey(MinecraftClient.getInstance().getWindow().getHandle(), GLFW.GLFW_KEY_RIGHT_CONTROL) == 1; |
There was a problem hiding this comment.
You aren't using the keybind you made for this in client init?
Also hard coding to ctrl is horrid because 70% of mc playerbase rebinds crouch to ctrl (which dismounts the horse)
There was a problem hiding this comment.
I was told by Fyoncle(who asked me to fix the issue) that the player's inventory should be opened by holding control and pressing E, if a horse is mounted(default key combination), while users can rebind a key without the need of using specific combination.
There was a problem hiding this comment.
This entire file isn't necessary, just use the exact keybind code found in main or girlinpurples pr
There was a problem hiding this comment.
Based on my first reply it is necessary.
- Fixed player inventory keybind issues if sprint set to toggle - Backported the excluding undead horses for swimming feature - Merged GirlInPurple's changes as they were not present in this branch.
Remove accidentally added unused import.
CodeF53
left a comment
CodeF53
left a comment
There was a problem hiding this comment.
Still needs an updated workflow file but otherwise lgtm
|
wait the flow was updated, then why did the build fail |
2 participants
