Update dependencies to allow route guard code to work#4
Open
ghostal wants to merge 1 commit intoCode-Pop:L9-startfrom
Open
Update dependencies to allow route guard code to work#4ghostal wants to merge 1 commit intoCode-Pop:L9-startfrom
ghostal wants to merge 1 commit intoCode-Pop:L9-startfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Gregg! First off, thanks a lot for the course. I'm enjoying learning from it, and especially enjoying the outtakes 😄
I came across a problem with the route guard code, whereby Vue would complain that
next()wasn't being run, meaning it considered the route guard to be invalid. Eventually I found the helpful comments by and @platoputhur @Bruce9000 in issue #2.That got me back on track, and I thought I'd open a PR so the code can be easily updated.
All I've done here is run
npm updateon the end of theL9-startbranch and commit the updatedpackage-lock.json.As far as I can gather, the key change the solves the problem is that the
vue-routerpackage moves from4.0.0-beta.9to4.0.12.