Skip to content

Conversation

@bhuvanh66
Copy link

ℹ️ Issue

Closes 47

📝 Description

I added a migration file that populates all of our table with a few rows of sample seed data. I also added the migration to our typeorm config file.

✔️ Verification

Tested each table in postgres to see if it was populated.

🏕️ (Optional) Future Work / Notes

Dummy data will need to be updated as database migration files are created. Also it may be worth considering typeorm seeding to be able to generate new test data

Juwang110 pushed a commit that referenced this pull request Nov 7, 2025
@bhuvanh66 bhuvanh66 requested a review from amywng November 11, 2025 02:21
@amywng
Copy link
Member

amywng commented Nov 12, 2025

think you might want to merge main because Sam did some updates to the pantry entity which might cause some problems with the data you're adding

Copy link
Member

@amywng amywng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll send you what i got for what pantry data should look like on slack but it's also in this pr

@bhuvanh66 bhuvanh66 requested a review from amywng November 24, 2025 02:34
@amywng amywng removed the blocked label Nov 26, 2025
@bhuvanh66 bhuvanh66 requested a review from amywng December 3, 2025 05:45
@bhuvanh66 bhuvanh66 requested a review from amywng December 4, 2025 02:38
Copy link
Member

@amywng amywng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think you added the activities comments column

@Code-4-Community Code-4-Community deleted a comment from bhuvanh66 Dec 6, 2025
@Juwang110 Juwang110 requested a review from amywng January 12, 2026 00:06
@sam-schu sam-schu removed the blocked label Jan 12, 2026
@sam-schu sam-schu assigned sam-schu and Juwang110 and unassigned sam-schu Jan 12, 2026
Copy link

@dburkhart07 dburkhart07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small deletion, but aside from that LGTM!

('Organic Suppliers LLC', (SELECT user_id FROM public.users WHERE email = 'jennifer.t@organic.com' LIMIT 1))
`);

await queryRunner.query(`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may not need these inserted, primarily because we already have a pantry_user_id field in the pantry table. The role is just to essentially say this person is a pantry representative I believe.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as Bhuvan had it though the pantry tables are linked to these users by that pantry_user_id. There is dummy data for actual users with that pantry role (lines 18-20). I could make some more of those and link them by pantry_user_id but I'm wondering if that is really necessary. I think it is fine as is? lmk ur thoughts

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially also did not want people to get confused that pantries were also users, but after a second look I think this will not be the case. This should be good then, thanks for picking this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants