Skip to content

Conversation

@not-matthias
Copy link
Member

@not-matthias not-matthias commented Dec 15, 2025

Fixes #44

Since we're modifying the code for our custom Go runner, we need to properly fix the paths used in the URI. We already replaced _codspeed.go with _test.go, but we also have to remove the codspeed/ folder which is used for integration tests.

@not-matthias not-matthias force-pushed the cod-1811-incorrect-file-path-on-the-benchmark-result branch 3 times, most recently from 36a2c6f to 13695f1 Compare December 15, 2025 10:08
@not-matthias not-matthias requested a review from Copilot December 15, 2025 10:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a utility function to remove the "codspeed" folder from file paths in the testing framework, improving the user experience by cleaning up file paths shown in test output and benchmark metadata. The change is part of handling integration tests that use codspeed benchmark files.

Key Changes:

  • Added removeFolderFromPath() helper function to strip "codspeed" folder from file paths
  • Applied folder removal in two contexts: callsite reporting and benchmark file tracking
  • Imported strings package to support the new functionality

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
testing/testing/codspeed.go Added new removeFolderFromPath function that strips specified folder names from paths by splitting on path separator
testing/testing/testing.go Applied folder removal to callsite file paths when handling _codspeed.go files
testing/testing/benchmark.go Applied folder removal to benchmark file paths when processing codspeed benchmark results

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 15, 2025

CodSpeed Performance Report

Merging #45 will improve performances by 21.83%

Comparing cod-1811-incorrect-file-path-on-the-benchmark-result (bbc9ccc) with main (a88bf0f)

Summary

⚡ 1 improvement
✅ 47 untouched
🆕 1 new

Benchmarks breakdown

Benchmark BASE HEAD Change
bench_collect_results[10000000, 25] 6.1 s 5 s +21.83%
🆕 BenchmarkExternalFib N/A 45 ns N/A

@not-matthias not-matthias force-pushed the cod-1811-incorrect-file-path-on-the-benchmark-result branch 2 times, most recently from f3421ba to f042bfc Compare December 15, 2025 12:50
@not-matthias not-matthias requested a review from Copilot December 15, 2025 12:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@not-matthias not-matthias force-pushed the cod-1811-incorrect-file-path-on-the-benchmark-result branch from f042bfc to f3513dc Compare December 15, 2025 13:55
Copy link
Member

@adriencaccia adriencaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's just make the benchmarks more relevant

@not-matthias not-matthias force-pushed the cod-1811-incorrect-file-path-on-the-benchmark-result branch from f3513dc to bbc9ccc Compare December 15, 2025 16:01
@not-matthias not-matthias merged commit bbc9ccc into main Dec 15, 2025
17 checks passed
@not-matthias not-matthias deleted the cod-1811-incorrect-file-path-on-the-benchmark-result branch December 15, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect file path on the benchmark result

3 participants