Update the polynomial coefficients calculation #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et_poly_coff using Wang et al. 2025 method
…for the last annulus
Owner
Author
|
These failing checks seem to be in the GitHub network I have run the local tests and checks, and we can merge this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in Wang et al. 2025, the new method can improve the numerical stability, especially for the planetary configuration. This implementation is important to the robustness of the gradient calculation, thus to the convergence of Hamiltonian Monte Carlo.
The attached figures show an example before and after updating the coefficients calculation
