Skip to content

ci: fix windows go coverage package parsing#108

Merged
RyshMan merged 1 commit intomainfrom
fix/gha-23329814099
Mar 20, 2026
Merged

ci: fix windows go coverage package parsing#108
RyshMan merged 1 commit intomainfrom
fix/gha-23329814099

Conversation

@RyshMan
Copy link
Copy Markdown
Contributor

@RyshMan RyshMan commented Mar 20, 2026

Problem

The nightly-full-windows workflow was failing in the Go tests with coverage step because Windows carriage returns were reaching go test package arguments and producing malformed import paths like github.com/Clyra-AI/gait/cmd/gait\r.

Changes

  • emit LF-only bytes from scripts/list_go_test_packages.py so package output is stable across platforms
  • defensively strip trailing \r values in the bash package-loading loops used by CI and the Windows nightly workflow
  • preserve existing non-Windows behavior while hardening the Windows path

Validation

  • ./gait doctor --json
  • make prepush-full
  • repo pre-push hook via git push (make prepush)

@RyshMan RyshMan requested a review from davidahmann as a code owner March 20, 2026 17:25
@RyshMan RyshMan merged commit cb71cb5 into main Mar 20, 2026
7 checks passed
@RyshMan RyshMan deleted the fix/gha-23329814099 branch March 20, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant