Skip to content

fix: stabilize gosec lint concurrency for release#106

Merged
RyshMan merged 1 commit intomainfrom
codex/release-prep-gosec-go126
Mar 20, 2026
Merged

fix: stabilize gosec lint concurrency for release#106
RyshMan merged 1 commit intomainfrom
codex/release-prep-gosec-go126

Conversation

@RyshMan
Copy link
Copy Markdown
Contributor

@RyshMan RyshMan commented Mar 20, 2026

Problem

  • release preflight on macOS hit a nondeterministic gosec panic (fatal error: concurrent map read and map write) during make prepush-full
  • the crash blocked cutting the next release from main

Root cause

  • gosec v2.23.0 runs with default concurrency 8, which proved flaky under the current local toolchain during repo-wide scans

Fix

  • run gosec single-threaded from the Makefile via a GOSEC_CONCURRENCY knob defaulted to 1
  • match the same -concurrency 1 invocation in GitHub Actions lint so local and CI behavior stay aligned

Validation

  • bash scripts/test_github_action_runtime_versions.sh
  • make lint
  • make prepush-full

@RyshMan RyshMan requested a review from davidahmann as a code owner March 20, 2026 01:27
@RyshMan RyshMan merged commit 949f936 into main Mar 20, 2026
7 checks passed
@RyshMan RyshMan deleted the codex/release-prep-gosec-go126 branch March 20, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant