Skip to content

hotfix: support ci package list on mac bash (r1)#105

Merged
RyshMan merged 1 commit intomainfrom
codex/hotfix-ci-package-list-r1
Mar 19, 2026
Merged

hotfix: support ci package list on mac bash (r1)#105
RyshMan merged 1 commit intomainfrom
codex/hotfix-ci-package-list-r1

Conversation

@RyshMan
Copy link
Copy Markdown
Contributor

@RyshMan RyshMan commented Mar 19, 2026

Problem

  • post-merge main CI failed in the ci workflow on macos-latest
  • the new Go coverage package-list step used mapfile, which is unavailable in the Bash version on GitHub's macOS runners
  • that caused the package array to stay empty and go test to run against . instead of the filtered package set

Changes

  • replace mapfile with a Bash 3.2-compatible while read array population loop in the ci workflow
  • apply the same package-loading pattern to the matching nightly Windows workflow step so the coverage logic stays consistent

Validation

  • make prepush-full
  • git push -u origin codex/hotfix-ci-package-list-r1 (pre-push hook ran make prepush)

@RyshMan RyshMan requested a review from davidahmann as a code owner March 19, 2026 23:15
@RyshMan RyshMan merged commit 1700f5e into main Mar 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant