-
Notifications
You must be signed in to change notification settings - Fork 94
Fix: log: Add milliseconds time format to crmsh.log (bsc#1255021) #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix: log: Add milliseconds time format to crmsh.log (bsc#1255021) #1996
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
em, the datefmt is conflicted with @nicholasyang2022 What do you think? Now I think since crm report can |
|
I don't think this is a valid request. Parsing an ISO timestamp is much easier and reliable than guessing the year. |
OK, then I will keep the datefmt unchanged, just add milliseconds |
No, ISO 8601 timestamp forbids milliseconds. I think the original request is to keep consistent format with pacemaker.log. So it won't help to add milliseconds. This is a suitable use case of |
Add milliseconds without milliseconds
If we add the |
This is totally wrong. If you must add milliseconds, it should be
I think it is OK to expose |
Uh oh!
There was an error while loading. Please reload this page.