Fix: bootstrap: On join node, retrieve qdevice data before starting qdevice (bsc#1254243) #1984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
liangxin1300
force-pushed
the
20251125_qdevice_issue
branch
3 times, most recently
from
fddae99 to
626d8ce
Compare
- Rename it to retrieve_data for reusability - Combine cpio with find to support retrieve directories recursively
liangxin1300
force-pushed
the
20251125_qdevice_issue
branch
from
626d8ce to
332eca0
Compare
liangxin1300
changed the title
This was referenced Nov 26, 2025
liangxin1300
force-pushed
the
20251125_qdevice_issue
branch
from
b2cb065 to
ae5fe39
Compare
liangxin1300
force-pushed
the
20251125_qdevice_issue
branch
from
ae5fe39 to
e58f46d
Compare
…device (bsc#1254243) Remove function start_qdevice_on_join_node, no need to do certificate on join node for qdevice
liangxin1300
force-pushed
the
20251125_qdevice_issue
branch
from
e58f46d to
8bb2c87
Compare
liangxin1300
changed the title
Collaborator
nicholasyang2022
left a comment
nicholasyang2022
left a comment
There was a problem hiding this comment.
The description of "Problem" and "Solution" is not so clear.
The name of the qdevice-related certification directory under /etc/corosync/qdevice/net is different between nodes, which might cause problems when the node re-joins the cluster.
How were they different? How did crmsh generate the directory name previously?
no need to do certificate on join node for qdevice
Why?
| cmd = 'cpio -o << EOF\n{}\nEOF\n'.format( | ||
| '\n'.join((f for f in get_files_to_sync() if f != CSYNC2_KEY and f != CSYNC2_CFG)) | ||
| ) | ||
| def retrieve_data(from_node, data_list=None, data_type=None): |
Collaborator
There was a problem hiding this comment.
- It would be more clear to name it
retrieve_filesinstead ofretrieve_data, as the word "data" is too general. - And also
file_list. data_typeis only used for outputting messages and has no actual functions. Passing it makes the code harder to understand. It would be better to passmsgdirectly, or use a more clear parameter name to reflect its usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When setup qdevice via init and join commands:
The name of the qdevice-related certification directory under
/etc/corosync/qdevice/netis different between nodes, which might cause problems when the node re-joins the clusterSolution
Refactor bootstrap.retrieve_all_config_files function
On join node, retrieve qdevice data before starting qdevice (bsc#1254243)
Remove function start_qdevice_on_join_node, no need to do certificate on join node for qdevice