[crmsh-5.0] Dev: sbd: Improve the process of leveraging maintenance mode #1951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
liangxin1300
force-pushed
the
20251022_improve_leverage_maintenance_mode_crmsh50
branch
from
c7c42b1 to
6258cfc
Compare
liangxin1300
force-pushed
the
20251022_improve_leverage_maintenance_mode_crmsh50
branch
from
6258cfc to
e753ef7
Compare
liangxin1300
force-pushed
the
20251022_improve_leverage_maintenance_mode_crmsh50
branch
2 times, most recently
from
0f33eb9 to
6fb23e1
Compare
- Drop the function `restart_cluster_if_possible` - Introduced a new function `utils.able_to_restart_cluster` to check if the cluster can be restarted. Call it before changing any configurations. - Add leverage maintenance mode in `sbd device remove` and `sbd purge` commands
And give error if the option is not crashdump
liangxin1300
force-pushed
the
20251022_improve_leverage_maintenance_mode_crmsh50
branch
from
f712baa to
7c277c9
Compare
| logger.warning("Please stop all running resources and try again") | ||
| logger.warning("Or use 'crm -F/--force' option to leverage maintenance mode") | ||
| logger.warning("Understand risks that running RA has no cluster protection while the cluster is in maintenance mode and restarting") | ||
| logger.info("INFO: Aborting the configuration change attempt") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from #1950