Skip to content

Conversation

@Markos-Th09
Copy link
Member

No description provided.

@Markos-Th09 Markos-Th09 requested review from Rosy-iso and Copilot June 3, 2025 14:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates several Rust crate dependencies to their latest versions, adjusts the getrandom feature for WebAssembly builds, and ensures the appropriate RUSTFLAGS are set in CI workflows.

  • Upgrade core, CLI, WASM, and workspace crate versions (e.g., serde, wasm-bindgen, phf, colored, criterion).
  • Switch getrandom feature to wasm_js and add RUSTFLAGS for WASM backends in test/build workflows.
  • Reformat the mlua dependency and bump its version.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
wasm/Cargo.toml Bumped serde, wasm-bindgen, updated clue_core features, switched getrandom to wasm_js.
core/Cargo.toml Bumped phf, serde, serde_json, and criterion versions.
cli/Cargo.toml Reformatted and bumped mlua dependency to v0.10.5.
Cargo.toml Updated workspace dependency versions (ahash, clap, colored, etc.).
.github/workflows/test.yml Added RUSTFLAGS: --cfg getrandom_backend="wasm_js" to WASM tests.
.github/workflows/build.yml Added RUSTFLAGS: --cfg getrandom_backend="wasm_js" to WASM build.
Comments suppressed due to low confidence (3)

wasm/Cargo.toml:20

  • [nitpick] You removed default-features = false, which may unintentionally enable default features from clue_core. Consider re-adding default-features = false if you only intend to enable serde.
clue_core = { path = "../core", version = "4.0.0-78ce10c1", features = [

Cargo.toml:20

  • [nitpick] Upgrading colored from v2.x to v3.x is a major version bump and may include breaking changes. Verify that all calls to its API still compile and behave as expected.
colored = "3.0.0"

core/Cargo.toml:25

  • [nitpick] Moving criterion to v0.6.0 could introduce changes in benchmark configuration. Ensure your benchmark setup and CI reporting still work with the new version.
criterion = "0.6.0"

@Rosy-iso Rosy-iso merged commit 9f6ece5 into ClueLang:next Jun 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants