Dark mode: fix nav text, team name centering, event/RNG page whites, live chart colour updates#156
Draft
Dark mode: fix nav text, team name centering, event/RNG page whites, live chart colour updates#156
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- FOUC-prevention script in <head> applies saved theme before first paint - Theme toggle button in nav cycles: System → Light → Dark → System - System mode follows OS/browser preference via prefers-color-scheme - Choice persisted in localStorage under 'theme-preference' - Comprehensive dark-mode CSS via SCSS mixin applied to [data-theme="dark"] attribute and @media (prefers-color-scheme: dark) media query - All pages covered through the shared default layout Co-authored-by: jetzlstorfer <7677092+jetzlstorfer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add light and dark mode support for all sub pages
Add light/dark mode with nav toggle button
Mar 3, 2026
…t colors - Toggle button: remove system mode, use sun/moon icons only, default follows OS via prefers-color-scheme, migrates legacy 'system' value - Team page: add dark mode CSS for .team-member white boxes and text - Statistics charts: detect dark mode at init, use readable tick/grid colors (light gray) when in dark mode Co-authored-by: jetzlstorfer <7677092+jetzlstorfer@users.noreply.github.com>
Copilot
AI
changed the title
Add light/dark mode with nav toggle button
Add light/dark mode with nav toggle, fix team/stats pages in dark mode
Mar 3, 2026
Co-authored-by: jetzlstorfer <7677092+jetzlstorfer@users.noreply.github.com>
…ixes Co-authored-by: jetzlstorfer <7677092+jetzlstorfer@users.noreply.github.com>
- generate-random-numbers.js: detect isDark at call time and apply theme-aware background/color as inline styles (root cause was JS inline style specificity (1,0,0) overriding all CSS rules) - default.html: dispatch 'themechange' CustomEvent in applyTheme() - statistics.md: getChartColors() helper + chartInstances[] + themechange listener → chart tick/grid colours update instantly on toggle - event.html: dark mode overrides for .event-detail-card (big white box), .talk-card, .slides-container, .video-container, .meta-badge, .event-detail-title, h4 inline colours, .no-slides-message Co-authored-by: jetzlstorfer <7677092+jetzlstorfer@users.noreply.github.com>
Copilot
AI
changed the title
Add light/dark mode with nav toggle, fix team/stats pages in dark mode
Dark mode: fix white boxes, live chart updates, result card, event page
Mar 3, 2026
Copilot
AI
changed the title
Dark mode: fix white boxes, live chart updates, result card, event page
Dark mode: fix nav text, team name centering, event/RNG page whites, live chart colour updates
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several pages had incomplete dark mode support, and chart colours only updated after a full page reload.
Nav bar & team page
#818cf8) by the generica {}dark-mode rule instyle.scss— fixed by adding an explicit.nav-linkoverride inside thedark-thememixinh3) and role weretext-align: left— changed tocenterto match the rest of the cardEvent detail page (
event.html)Hard-coded white/light backgrounds in the inline
<style>block. Added[data-theme="dark"]+@media (prefers-color-scheme: dark)overrides for:.event-detail-card(the large white box).talk-card,.slides-container,.video-container.meta-badge,.event-detail-title, h4 inline colours,.no-slides-messageRandom number generator (
random-number-generator.html+generate-random-numbers.js).form-label,.form-input,.result-card,.result-headergenerate-random-numbers.jswas writingresultCard.style.backgroundandresultHeader.style.coloras inline styles (specificity1,0,0), which defeated every CSS rule. Fixed by reading the active theme at call time and applying the correct value directly:Live chart colour updates (
default.html+statistics.md)Charts read
isDarkonce atDOMContentLoaded; toggling the mode had no effect without a reload.applyTheme()indefault.htmlnow dispatches athemechangeCustomEvent after applying the new themestatistics.mdextracts agetChartColors()helper, stores all three Chart.js instances in achartInstances[]array, and listens forthemechangeto update tick/grid colours and callchart.update('none')on each — no reload neededOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.