forked from langgenius/dify
-
Notifications
You must be signed in to change notification settings - Fork 3
fix arm repo #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
konpure
wants to merge
9
commits into
CloudDetail:release-ci
Choose a base branch
from
konpure:apo-1.0.0
base: release-ci
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix arm repo #44
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refactors the GitHub workflows for API and web image releases by inlining registry paths, correcting ARM image prefixes and adding a manual tag push step. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @konpure - I've reviewed your changes - here's some feedback:
- The ARM jobs are tagging images under the “originx” namespace while AMD64 uses “kindlingx”—please verify if that difference is intentional or needs alignment.
- Your ARM tags no longer include a “-arm64” suffix, which could overwrite the AMD64 tag; consider reintroducing the suffix or using a multi-arch manifest.
- To reduce repetition, you could re-add an IMAGE_BASE env var (scoped per job) instead of hardcoding the registry path in every tag definition.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The ARM jobs are tagging images under the “originx” namespace while AMD64 uses “kindlingx”—please verify if that difference is intentional or needs alignment.
- Your ARM tags no longer include a “-arm64” suffix, which could overwrite the AMD64 tag; consider reintroducing the suffix or using a multi-arch manifest.
- To reduce repetition, you could re-add an IMAGE_BASE env var (scoped per job) instead of hardcoding the registry path in every tag definition.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Tip
Close issue syntax:
Fixes #<issue number>orResolves #<issue number>, see documentation for more details.Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsSummary by Sourcery
Update GitHub Actions release workflows to fix ARM64 image repository paths and add automated tag pushing.
CI: