Skip to content

Conversation

@konpure
Copy link

@konpure konpure commented Aug 12, 2025

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Summary by Sourcery

Update GitHub Actions release workflows to fix ARM64 image repository paths and add automated tag pushing.

CI:

  • Correct image tags to use explicit registry paths for both API and web (kindlingx for amd64, originx for arm64) instead of IMAGE_BASE env var
  • Add a conditional 'push tag' step using github-tag-action on workflow_dispatch events

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refactors the GitHub workflows for API and web image releases by inlining registry paths, correcting ARM image prefixes and adding a manual tag push step.

File-Level Changes

Change Details Files
Inline registry host directly in image tags, removing the shared IMAGE_BASE variable
  • Removed IMAGE_BASE environment variable
  • Replaced tag definitions with explicit ${{ env.REGISTRY_HOST }}/... paths
.github/workflows/release-image-api.yml
.github/workflows/release-image-web.yml
Correct ARM64 image repository path and normalize tag naming
  • Switched ARM64 tags from kindlingx to originx prefix
  • Dropped the -arm64 suffix from image tags
.github/workflows/release-image-api.yml
.github/workflows/release-image-web.yml
Add a conditional manual tag push step
  • Added a push tag job that runs on workflow_dispatch
  • Configured anothrNick/github-tag-action@v1 with GITHUB_TOKEN
.github/workflows/release-image-api.yml
.github/workflows/release-image-web.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @konpure - I've reviewed your changes - here's some feedback:

  • The ARM jobs are tagging images under the “originx” namespace while AMD64 uses “kindlingx”—please verify if that difference is intentional or needs alignment.
  • Your ARM tags no longer include a “-arm64” suffix, which could overwrite the AMD64 tag; consider reintroducing the suffix or using a multi-arch manifest.
  • To reduce repetition, you could re-add an IMAGE_BASE env var (scoped per job) instead of hardcoding the registry path in every tag definition.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The ARM jobs are tagging images under the “originx” namespace while AMD64 uses “kindlingx”—please verify if that difference is intentional or needs alignment.
- Your ARM tags no longer include a “-arm64” suffix, which could overwrite the AMD64 tag; consider reintroducing the suffix or using a multi-arch manifest.
- To reduce repetition, you could re-add an IMAGE_BASE env var (scoped per job) instead of hardcoding the registry path in every tag definition.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants