Implementation universal presets #492
Open
+310
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S1mpotyaga
requested review from
ArtyomPeshkov and
PaulRalnikov
and removed request for
ArtyomPeshkov and
PaulRalnikov
PaulRalnikov
requested changes
Jan 27, 2026
Collaborator
PaulRalnikov
left a comment
PaulRalnikov
left a comment
There was a problem hiding this comment.
Good job, but some changes needed
Az3git
reviewed
Jan 28, 2026
Contributor
Az3git
left a comment
Az3git
left a comment
There was a problem hiding this comment.
LGTM!
Please check clang-format:
python3 -m venv venv
./venv/bin/pip install "clang-format==19.1.3"
After commit:
Check: ./venv/bin/clang-format --dry-run -Werror $(git ls-files 'source/.cpp' 'source/.hpp' 'test/.cpp' 'test/.hpp')
Automatic error correction: ./venv/bin/clang-format -i $(git ls-files 'source/.cpp' 'source/.hpp' 'test/.cpp' 'test/.hpp')
PaulRalnikov
requested changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #484