Open
Conversation
Ivana-
reviewed
Jan 5, 2025
Ivana-
left a comment
Ivana-
left a comment
There was a problem hiding this comment.
Аккуратно, хорошо, с комментариями, ленивым чтением файлов и мультиметодами :) Пару несущественных моментов отметил в ревью
| ; Парсим описания схем для удобства. | ||
| (def db | ||
| (->> db-description | ||
| (map (fn [[table {path :path schema :schema}]] |
There was a problem hiding this comment.
Вопрос вкуса, но имхо короче
(reduce (fn [acc [k v]] (assoc acc k (update v :schema parse-schema))) nil db-description)
|
|
||
| (defn print-menu | ||
| "Печатает на экран меню." | ||
| [menu] |
There was a problem hiding this comment.
[{:keys [title options exit message]}] и гораздо меньше визуального шума в коде ниже
|
|
||
| (defn main-loop | ||
| "Показывает меню и выполняет действия в зависимости от выбора пользователя." | ||
| [menu] |
There was a problem hiding this comment.
Тот же самый дистракчеринг, что и выше, имхо был бы очень удобен
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.