Draft
Conversation
XOMAv2
suggested changes
Feb 25, 2025
Comment on lines
+16
to
+25
| (deftest id->int-test | ||
| (testing "Legal arguments" | ||
| (are [res value] (= res (id->int value)) | ||
| 1 "1" | ||
| 61 "z" | ||
| 725410830262 "Clojure" | ||
| 149031 "clj")) | ||
| (testing "Illegal arguments" | ||
| (is (thrown? java.lang.NullPointerException | ||
| (id->int "_"))))) |
There was a problem hiding this comment.
Проверка граничных значений: nil и пустая строка.
Comment on lines
+5
to
+14
| (deftest test-int->id | ||
| (testing "Legal arguments" | ||
| (are [res value] (= res (int->id value)) | ||
| "1" 1 | ||
| "10" 62 | ||
| "2q3Rktod" 9999999999999 | ||
| "AzL8n0Y58W7" Long/MAX_VALUE)) | ||
| (testing "Illegal arguments" | ||
| (is (thrown? java.lang.ClassCastException | ||
| (int->id "_"))))) |
There was a problem hiding this comment.
Добавь проверки для граничных значений: 0, nil, Long/MIN_VALUE
| (deftest a-test | ||
| (testing "FIXME, I fail." | ||
| (is (= 0 1)))) | ||
| (deftest test-int->id |
There was a problem hiding this comment.
Имя этого теста ты начинаешь с test-, а имя второго ты заканчиваешь -test. Выбери единообразное именование для тестов.
|
|
||
| (deftest id->int-test | ||
| (testing "Legal arguments" | ||
| (are [res value] (= res (id->int value)) |
There was a problem hiding this comment.
Думаю полезно было бы добавить несколько тестов на композицию функций (comp id->int int->id)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
homework for otus-08