fix(release): fallback root version when git-cliff does not advance it#16
Merged
fix(release): fallback root version when git-cliff does not advance it#16
Conversation
Guard the root versioning step when pending changesets exist but git-cliff returns the current version. In that case, bump the root patch version so changesets can still open the version PR instead of failing with "Version not changed".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/changeset-version.shchangesets/actionwhen pending changesets exist butgit-cliff --bumpreturns the current root version@clinwise/release-scriberelease path from PR#15Root cause
The custom version script tried to run
pnpm versionwith the unchanged root version0.3.0.That happened because the repository had pending changesets, but the unreleased git-cliff bump still resolved to the current root version.
Validation
23044660593bash -x ./scripts/changeset-version.sh0.3.1pnpm changeset versioncompletes and plans@clinwise/release-scribe 0.1.0 -> 0.1.1