Skip to content

Conversation

@treigerm
Copy link
Member

This slightly reduces the bounding box that determines what data is included in the benchmark. The uncompressed size of the biomass data is now 382MB. This makes all compressors pass instead of the PCO ones. This seems acceptable to me now and I'm hesitant to make the bounding box any smaller because we want to make sure we capture at least some variability even for the tiny benchmark.

Also given that you identified the issue with PCO (pcodec/pcodec#298) @juntyr , it is not necessarily an issue on our end.

Visualization of the bounding box:
image

@juntyr
Copy link
Collaborator

juntyr commented Jun 16, 2025

@treigerm I think this will mostly help with JPEG in the end since PCO and ZFP are upstream issues that I'm working on getting fixed. But if JPEG is really just an OOM problem then a small reduction would help.

@juntyr
Copy link
Collaborator

juntyr commented Jun 16, 2025

I’ll investigate a bit more and then we’ll see if we need this change, thanks for putting it up!

@treigerm
Copy link
Member Author

Sounds good, of course if we can fix this otherwise that will be better! I just also needed a short term fix for now.

@juntyr
Copy link
Collaborator

juntyr commented Jul 2, 2025

Since we now have fixes for all compressors to work on the original size (ClimateBenchPress/compressor#44, ClimateBenchPress/compressor#45, ClimateBenchPress/compressor#46), I close this PR

@juntyr juntyr closed this Jul 2, 2025
@treigerm treigerm deleted the reduce_biomass branch July 31, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants